You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "rmannibucau (via GitHub)" <gi...@apache.org> on 2024/03/23 20:20:25 UTC

[PR] Make ConnectionHandler accessible through API from AbstractProtocol to ultimately acess RequestGroupInfo [tomcat]

rmannibucau opened a new pull request, #711:
URL: https://github.com/apache/tomcat/pull/711

   Goal is to be able to have metrics without having to re-register them or to use reflection, even when JMX is disabled - including GraalVM case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [PR] Make ConnectionHandler accessible through API from AbstractProtocol to ultimately acess RequestGroupInfo [tomcat]

Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on code in PR #711:
URL: https://github.com/apache/tomcat/pull/711#discussion_r1636187299


##########
java/org/apache/coyote/AbstractProtocol.java:
##########
@@ -769,7 +769,7 @@ private void logPortOffset() {
 
     // ------------------------------------------- Connection handler base class
 
-    protected static class ConnectionHandler<S> implements AbstractEndpoint.Handler<S> {
+    public static class ConnectionHandler<S> implements AbstractEndpoint.Handler<S> {

Review Comment:
   Had the idea to make getGlobal returning RequestInfo directly (`public RequestGroupInfo getGlobal() { return global; }`) but didn't push it so you are right, will revert this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [PR] Make ConnectionHandler accessible through API from AbstractProtocol to ultimately acess RequestGroupInfo [tomcat]

Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on code in PR #711:
URL: https://github.com/apache/tomcat/pull/711#discussion_r1636159961


##########
java/org/apache/coyote/AbstractProtocol.java:
##########
@@ -769,7 +769,7 @@ private void logPortOffset() {
 
     // ------------------------------------------- Connection handler base class
 
-    protected static class ConnectionHandler<S> implements AbstractEndpoint.Handler<S> {
+    public static class ConnectionHandler<S> implements AbstractEndpoint.Handler<S> {

Review Comment:
   Why do you need this change? Isn't the change to 'getHandler()' sufficient to expose the global request processor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [PR] Make ConnectionHandler accessible through API from AbstractProtocol to ultimately acess RequestGroupInfo [tomcat]

Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf merged PR #711:
URL: https://github.com/apache/tomcat/pull/711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org