[GitHub] [cassandra] blerer commented on a change in pull request #1528: CASSANDRA-17458 Fix timing issue in testPartitionDeletionRangeDeletionTie test case

[GitBox <gi...@apache.org>]

blerer commented on a change in pull request #1528:
URL: https://github.com/apache/cassandra/pull/1528#discussion_r836360872



##########
File path: src/java/org/apache/cassandra/cql3/QueryProcessor.java
##########
@@ -575,7 +575,7 @@ private static UntypedResultSet executeOnceInternal(QueryState queryState, Strin
     {
         CQLStatement statement = parseStatement(query, queryState.getClientState());
         statement.validate(queryState.getClientState());
-        ResultMessage result = statement.executeLocally(queryState, makeInternalOptions(statement, values));
+        ResultMessage result = statement.executeLocally(queryState, makeInternalOptionsWithNowInSec(statement, queryState.getNowInSeconds(), values));

Review comment:
       I am a bit confused with the change. I feel that the change should be at the test level not at the QueryProcessor level.
   Could you elaborate on why you believe that we should modify the code here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org