You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xushiyan (via GitHub)" <gi...@apache.org> on 2023/05/17 08:41:13 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #8736: [HUDI-5724] Fix merger api usage with more UTs

xushiyan commented on code in PR #8736:
URL: https://github.com/apache/hudi/pull/8736#discussion_r1196151708


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSourceStorage.scala:
##########
@@ -132,89 +129,4 @@ class TestMORDataSourceStorage extends SparkClientFunctionalTestHarness {
     assertEquals(100, hudiSnapshotDF3.count())
     assertEquals(updatedVerificationVal, hudiSnapshotDF3.filter(col("_row_key") === verificationRowKey).select(verificationCol).first.getString(0))
   }
-
-  @ParameterizedTest
-  @CsvSource(Array(
-    "true,GLOBAL_SIMPLE",
-    "true,GLOBAL_BLOOM",
-    "false,GLOBAL_SIMPLE",
-    "false,GLOBAL_BLOOM"
-  ))
-  def testMergeOnReadStorageWithGlobalIndexUpdatePartition(isMetadataEnabled: Boolean, indexType: String): Unit = {

Review Comment:
   this test case is covered in the new one added to hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestGlobalIndexEnableUpdatePartitions.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org