You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/20 09:30:39 UTC
[GitHub] [spark] cloud-fan opened a new pull request #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
cloud-fan opened a new pull request #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Skew join handling comes with an overhead: we need to read some data repeatedly. We should treat a partition as skewed if it's large enough so that it's beneficial to do so.
Currently the size threshold is the advisory partition size, which is 64 MB by default. This is not large enough for the skewed partition size threshold.
This PR adds a new config for the threshold and set default value as 256 MB.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Avoid skew join handling that may introduce a perf regression.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601611188
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601611188
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601611197
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120091/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603901159
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603157351
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24976/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601609188
**[Test build #120091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120091/testReport)** for PR 27967 at commit [`18eb8c9`](https://github.com/apache/spark/commit/18eb8c9559a2c56724f4623473a31c9d7261dc87).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602763775
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120208/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601611197
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120091/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603722984
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25039/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603030421
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120228/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603726123
**[Test build #120330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120330/testReport)** for PR 27967 at commit [`914eaf5`](https://github.com/apache/spark/commit/914eaf59db2beb11a1ac843acd5b2ae59e612315).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603722984
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25039/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r397630336
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -67,7 +67,7 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends Rule[SparkPlan] {
*/
private def isSkewed(size: Long, medianSize: Long): Boolean = {
size > medianSize * conf.getConf(SQLConf.SKEW_JOIN_SKEWED_PARTITION_FACTOR) &&
- size > conf.getConf(SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES)
+ size > conf.getConf(SQLConf.SKEW_JOIN_SKEWED_PARTITION_THRESHOLD)
Review comment:
We'd better to update doc to warn user not to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603901170
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120330/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601609923
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601609926
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24807/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r397560722
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -67,7 +67,7 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends Rule[SparkPlan] {
*/
private def isSkewed(size: Long, medianSize: Long): Boolean = {
size > medianSize * conf.getConf(SQLConf.SKEW_JOIN_SKEWED_PARTITION_FACTOR) &&
- size > conf.getConf(SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES)
+ size > conf.getConf(SQLConf.SKEW_JOIN_SKEWED_PARTITION_THRESHOLD)
Review comment:
Do we still guarantee this after having s separate conf?
https://github.com/apache/spark/blob/30d95356f1881c32eb39e51525d2bcb331fcf867/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala#L196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602763775
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120208/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603030421
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120228/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603157342
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603310233
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120265/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603722976
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602588368
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] Add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603309111
**[Test build #120265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120265/testReport)** for PR 27967 at commit [`bf85ee1`](https://github.com/apache/spark/commit/bf85ee1e101a8819525e3890d0a9a639cd96e3f2).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603157342
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601611174
**[Test build #120091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120091/testReport)** for PR 27967 at commit [`18eb8c9`](https://github.com/apache/spark/commit/18eb8c9559a2c56724f4623473a31c9d7261dc87).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601609926
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24807/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603029842
**[Test build #120228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120228/testReport)** for PR 27967 at commit [`1976bf7`](https://github.com/apache/spark/commit/1976bf79318c7e3119315d7e59386988e61465c5).
* This patch **fails PySpark pip packaging tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] Add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603156819
**[Test build #120265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120265/testReport)** for PR 27967 at commit [`bf85ee1`](https://github.com/apache/spark/commit/bf85ee1e101a8819525e3890d0a9a639cd96e3f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r397011044
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -490,12 +490,21 @@ object SQLConf {
buildConf("spark.sql.adaptive.skewJoin.skewedPartitionFactor")
.doc("A partition is considered as skewed if its size is larger than this factor " +
"multiplying the median partition size and also larger than " +
- s"'${ADVISORY_PARTITION_SIZE_IN_BYTES.key}'")
+ s"'spark.sql.adaptive.skewJoin.skewedPartitionThresholdInBytes'")
.version("3.0.0")
.intConf
.checkValue(_ > 0, "The skew factor must be positive.")
.createWithDefault(10)
+ val SKEW_JOIN_SKEWED_PARTITION_THRESHOLD =
+ buildConf("spark.sql.adaptive.skewJoin.skewedPartitionThresholdInBytes")
+ .doc("A partition is considered as skewed if its size in bytes is larger than this " +
+ s"threshold and also larger than 'spark.sql.adaptive.skewJoin.skewedPartitionFactor' " +
Review comment:
I think you can use `${SKEW_JOIN_SKEWED_PARTITION_FACTOR.key}` at here - it won't cross reference or forward reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602588384
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24921/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r396334037
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -781,4 +782,3 @@ class AdaptiveQueryExecSuite
}
}
}
-
Review comment:
IIRC, we always need a new line at the end of a file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602960878
**[Test build #120228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120228/testReport)** for PR 27967 at commit [`1976bf7`](https://github.com/apache/spark/commit/1976bf79318c7e3119315d7e59386988e61465c5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] Add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603899568
**[Test build #120330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120330/testReport)** for PR 27967 at commit [`914eaf5`](https://github.com/apache/spark/commit/914eaf59db2beb11a1ac843acd5b2ae59e612315).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603157351
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24976/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602961216
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24941/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602961208
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603156819
**[Test build #120265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120265/testReport)** for PR 27967 at commit [`bf85ee1`](https://github.com/apache/spark/commit/bf85ee1e101a8819525e3890d0a9a639cd96e3f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601609188
**[Test build #120091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120091/testReport)** for PR 27967 at commit [`18eb8c9`](https://github.com/apache/spark/commit/18eb8c9559a2c56724f4623473a31c9d7261dc87).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27967: [SPARK-31201][SQL] add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602959649
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602763766
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r396917626
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -490,12 +490,21 @@ object SQLConf {
buildConf("spark.sql.adaptive.skewJoin.skewedPartitionFactor")
.doc("A partition is considered as skewed if its size is larger than this factor " +
"multiplying the median partition size and also larger than " +
- s"'${ADVISORY_PARTITION_SIZE_IN_BYTES.key}'")
+ s"'spark.sql.adaptive.skewJoin.skewedPartitionThresholdInBytes'")
Review comment:
nit: don't need s"" now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603901170
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120330/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r396333397
##########
File path: docs/sql-performance-tuning.md
##########
@@ -242,7 +242,14 @@ Data skew can severely downgrade the performance of join queries. This feature d
<td><code>spark.sql.adaptive.skewJoin.skewedPartitionFactor</code></td>
<td>10</td>
<td>
- A partition is considered as skewed if its size is larger than this factor multiplying the median partition size and also larger than <code>spark.sql.adaptive.advisoryPartitionSizeInBytes</code>.
+ A partition is considered as skewed if its size is larger than this factor multiplying the median partition size and also larger than <code>spark.sql.adaptive.skewedPartitionThresholdInBytes</code>.
+ </td>
+ </tr>
+ <tr>
+ <td><code>spark.sql.adaptive.skewJoin.skewedPartitionThresholdInBytes</code></td>
+ <td>10</td>
Review comment:
`256MB` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603030416
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-604445541
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602763766
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602591995
**[Test build #120208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120208/testReport)** for PR 27967 at commit [`1976bf7`](https://github.com/apache/spark/commit/1976bf79318c7e3119315d7e59386988e61465c5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r396438449
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -781,4 +782,3 @@ class AdaptiveQueryExecSuite
}
}
}
-
Review comment:
We still have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602961216
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24941/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602961208
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r397626940
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -67,7 +67,7 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends Rule[SparkPlan] {
*/
private def isSkewed(size: Long, medianSize: Long): Boolean = {
size > medianSize * conf.getConf(SQLConf.SKEW_JOIN_SKEWED_PARTITION_FACTOR) &&
- size > conf.getConf(SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES)
+ size > conf.getConf(SQLConf.SKEW_JOIN_SKEWED_PARTITION_THRESHOLD)
Review comment:
now it's possible, if people set `SKEW_JOIN_SKEWED_PARTITION_THRESHOLD` much lower than `ADVISORY_PARTITION_SIZE_IN_BYTES`. But that's more like a malformed setting and we should simply ignore it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603310218
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602588384
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24921/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602763039
**[Test build #120208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120208/testReport)** for PR 27967 at commit [`1976bf7`](https://github.com/apache/spark/commit/1976bf79318c7e3119315d7e59386988e61465c5).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603310233
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120265/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] Add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603726123
**[Test build #120330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120330/testReport)** for PR 27967 at commit [`914eaf5`](https://github.com/apache/spark/commit/914eaf59db2beb11a1ac843acd5b2ae59e612315).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603901159
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#discussion_r396917679
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -490,12 +490,21 @@ object SQLConf {
buildConf("spark.sql.adaptive.skewJoin.skewedPartitionFactor")
.doc("A partition is considered as skewed if its size is larger than this factor " +
"multiplying the median partition size and also larger than " +
- s"'${ADVISORY_PARTITION_SIZE_IN_BYTES.key}'")
+ s"'spark.sql.adaptive.skewJoin.skewedPartitionThresholdInBytes'")
.version("3.0.0")
.intConf
.checkValue(_ > 0, "The skew factor must be positive.")
.createWithDefault(10)
+ val SKEW_JOIN_SKEWED_PARTITION_THRESHOLD =
+ buildConf("spark.sql.adaptive.skewJoin.skewedPartitionThresholdInBytes")
+ .doc("A partition is considered as skewed if its size in bytes is larger than this " +
+ s"threshold and also larger than 'spark.sql.adaptive.skewJoin.skewedPartitionFactor' " +
Review comment:
ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602591995
**[Test build #120208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120208/testReport)** for PR 27967 at commit [`1976bf7`](https://github.com/apache/spark/commit/1976bf79318c7e3119315d7e59386988e61465c5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603310218
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] Add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603722976
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603030416
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27967: [SPARK-31201][SQL]
add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602588368
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27967: [SPARK-31201][SQL] add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-602960878
**[Test build #120228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120228/testReport)** for PR 27967 at commit [`1976bf7`](https://github.com/apache/spark/commit/1976bf79318c7e3119315d7e59386988e61465c5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27967:
[SPARK-31201][SQL] add an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27967: [SPARK-31201][SQL] add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-601609923
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27967: [SPARK-31201][SQL] Add
an individual config for skewed partition threshold
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27967: [SPARK-31201][SQL] Add an individual config for skewed partition threshold
URL: https://github.com/apache/spark/pull/27967#issuecomment-603733579
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org