You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by nakomis <gi...@git.apache.org> on 2014/10/03 12:11:38 UTC
[GitHub] incubator-brooklyn pull request: Feature/checkstyle plugin
GitHub user nakomis opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/210
Feature/checkstyle plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/incubator-brooklyn feature/checkstyle-plugin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #210
----
commit db48929c0565ee99aaa6a457d8bfad32bbe001fe
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-09-29T16:37:32Z
Adds maven checkstyle plugin with FileTabCharacter module
commit cfb89c7e9002987781277f3ebf81a09d80ceff1b
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-10-03T09:53:47Z
Replaces all tab characters in java files with four spaces
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Feature/checkstyle plugin
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/210#issuecomment-57792839
If other PRs are merged, and this PR needs to be rebased, it may be easier to simply undo the 'Replaces all tab characters...' commit and re-do it with the following (for MacOS):
```
`which -s gsed` || sudo port install gsed
find . -name "*.java" -exec gsed -i -e "s/\t/ /g" '{}' \;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Feature/checkstyle plugin
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/210#issuecomment-58442002
This can be closed in favour of https://github.com/apache/incubator-brooklyn/pull/232. I'll merge that once apache jenkins confirms it builds correctly.
@nakomis could you close this PR please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Feature/checkstyle plugin
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---