You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by ag...@apache.org on 2025/09/17 13:53:14 UTC
(datafusion-comet) branch main updated: feat: Enable WeekDay function (#2411)
This is an automated email from the ASF dual-hosted git repository.
agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new 9cac1af03 feat: Enable WeekDay function (#2411)
9cac1af03 is described below
commit 9cac1af03f14e93624749edb919b0f6405d5624f
Author: Zhen Wang <64...@qq.com>
AuthorDate: Wed Sep 17 21:53:10 2025 +0800
feat: Enable WeekDay function (#2411)
---
docs/source/user-guide/latest/expressions.md | 39 +++++++++++-----------
.../org/apache/comet/serde/QueryPlanSerde.scala | 4 +--
.../org/apache/comet/CometExpressionSuite.scala | 3 +-
3 files changed, 22 insertions(+), 24 deletions(-)
diff --git a/docs/source/user-guide/latest/expressions.md b/docs/source/user-guide/latest/expressions.md
index c29d0202b..144f93ac6 100644
--- a/docs/source/user-guide/latest/expressions.md
+++ b/docs/source/user-guide/latest/expressions.md
@@ -91,25 +91,26 @@ incompatible expressions.
## Date/Time Functions
-| Expression | SQL | Spark-Compatible? | Compatibility Notes |
-| -------------- |------------------------------| ----------------- |------------------------------------------------------------------------------------------------------|
-| DateAdd | `date_add` | Yes | |
-| DateSub | `date_sub` | Yes | |
-| DatePart | `date_part(field, source)` | Yes | Supported values of `field`: `year`/`month`/`week`/`day`/`dayofweek`/`doy`/`quarter`/`hour`/`minute` |
-| Extract | `extract(field FROM source)` | Yes | Supported values of `field`: `year`/`month`/`week`/`day`/`dayofweek`/`doy`/`quarter`/`hour`/`minute` |
-| FromUnixTime | `from_unixtime` | No | Does not support format, supports only -8334601211038 <= sec <= 8210266876799 |
-| Hour | `hour` | Yes | |
-| Minute | `minute` | Yes | |
-| Second | `second` | Yes | |
-| TruncDate | `trunc` | Yes | |
-| TruncTimestamp | `trunc_date` | Yes | |
-| Year | `year` | Yes | |
-| Month | `month` | Yes | |
-| DayOfMonth | `day`/`dayofmonth` | Yes | |
-| DayOfWeek | `dayofweek` | Yes | |
-| DayOfYear | `dayofyear` | Yes | |
-| WeekOfYear | `weekofyear` | Yes | |
-| Quarter | `quarter` | Yes | |
+| Expression | SQL | Spark-Compatible? | Compatibility Notes |
+|----------------|------------------------------| ----------------- |----------------------------------------------------------------------------------------------------------------------|
+| DateAdd | `date_add` | Yes | |
+| DateSub | `date_sub` | Yes | |
+| DatePart | `date_part(field, source)` | Yes | Supported values of `field`: `year`/`month`/`week`/`day`/`dayofweek`/`dayofweek_iso`/`doy`/`quarter`/`hour`/`minute` |
+| Extract | `extract(field FROM source)` | Yes | Supported values of `field`: `year`/`month`/`week`/`day`/`dayofweek`/`dayofweek_iso`/`doy`/`quarter`/`hour`/`minute` |
+| FromUnixTime | `from_unixtime` | No | Does not support format, supports only -8334601211038 <= sec <= 8210266876799 |
+| Hour | `hour` | Yes | |
+| Minute | `minute` | Yes | |
+| Second | `second` | Yes | |
+| TruncDate | `trunc` | Yes | |
+| TruncTimestamp | `trunc_date` | Yes | |
+| Year | `year` | Yes | |
+| Month | `month` | Yes | |
+| DayOfMonth | `day`/`dayofmonth` | Yes | |
+| DayOfWeek | `dayofweek` | Yes | |
+| WeekDay | `weekday` | Yes | |
+| DayOfYear | `dayofyear` | Yes | |
+| WeekOfYear | `weekofyear` | Yes | |
+| Quarter | `quarter` | Yes | |
## Math Expressions
diff --git a/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala b/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
index 6fd68569f..1e0e97862 100644
--- a/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
+++ b/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
@@ -207,9 +207,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
classOf[Month] -> CometMonth,
classOf[DayOfMonth] -> CometDayOfMonth,
classOf[DayOfWeek] -> CometDayOfWeek,
- // FIXME: current datafusion version does not support isodow (WeekDay)
- // , see: https://github.com/apache/datafusion-comet/issues/2330
- // classOf[WeekDay] -> CometWeekDay,
+ classOf[WeekDay] -> CometWeekDay,
classOf[DayOfYear] -> CometDayOfYear,
classOf[WeekOfYear] -> CometWeekOfYear,
classOf[Quarter] -> CometQuarter)
diff --git a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
index 6d7a5de7d..55b5121dd 100644
--- a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
@@ -1729,9 +1729,8 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
withTable(table) {
sql(s"create table $table(col timestamp) using parquet")
sql(s"insert into $table values (now()), (timestamp('1900-01-01')), (null)")
- // TODO: weekday(col) https://github.com/apache/datafusion-comet/issues/2330
checkSparkAnswerAndOperator(
- "SELECT col, year(col), month(col), day(col)," +
+ "SELECT col, year(col), month(col), day(col), weekday(col), " +
s" dayofweek(col), dayofyear(col), weekofyear(col), quarter(col) FROM $table")
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org