You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/07/01 03:36:00 UTC

[jira] [Commented] (GEODE-8323) Need to correctly process QueueRemovalMessage during HARegionQueue initialization

    [ https://issues.apache.org/jira/browse/GEODE-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149075#comment-17149075 ] 

ASF GitHub Bot commented on GEODE-8323:
---------------------------------------

pivotal-eshu opened a new pull request #5333:
URL: https://github.com/apache/geode/pull/5333


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Need to correctly process QueueRemovalMessage during HARegionQueue initialization
> ---------------------------------------------------------------------------------
>
>                 Key: GEODE-8323
>                 URL: https://issues.apache.org/jira/browse/GEODE-8323
>             Project: Geode
>          Issue Type: Bug
>          Components: client queues
>            Reporter: Eric Shu
>            Assignee: Eric Shu
>            Priority: Major
>              Labels: caching-applications
>
> Currently, these events in queue removal message are ignored as the idea is that correct setting of messageTimeToLive and subscriptionMessageTrackingTimeout should prevent a previous seen event replayed on a client. 
> However, it failover scenario occurs, a restarted/newly joined member could gii from a secondary HARegionQueue which has those events not removed by the QRM. As the restarted member starts the timer for messageTimeToLive after it restarted. The event could live longer than the messageTimeToLive setting if starts from the original operation time. If this time is longer than the subscriptionMessageTrackingTimeout setting on the client, the client will not prevent the replay of the stray event. This could leads to data inconsistency between client and server.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)