You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@crail.apache.org by PepperJo <gi...@git.apache.org> on 2018/11/12 10:37:38 UTC

[GitHub] incubator-crail pull request #64: [LICENSE] add licenses of dependencies

GitHub user PepperJo opened a pull request:

    https://github.com/apache/incubator-crail/pull/64

    [LICENSE] add licenses of dependencies

    Add licenses of all dependencies and their copyrights.
    
    https://jira.apache.org/jira/browse/CRAIL-81
    
    Signed-off-by: Jonas Pfefferle <pe...@apache.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PepperJo/incubator-crail license_dependencies

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-crail/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit c24c0d9b58b7b8a2704b3b19bd36f9005888d14b
Author: Jonas Pfefferle <pe...@...>
Date:   2018-11-12T10:24:31Z

    [LICENSE] add licenses of dependencies
    
    Add licenses of all dependencies and their copyrights.
    
    https://jira.apache.org/jira/browse/CRAIL-81
    
    Signed-off-by: Jonas Pfefferle <pe...@apache.org>

----


---

[GitHub] incubator-crail issue #64: [LICENSE] add licenses of dependencies

Posted by asqasq <gi...@git.apache.org>.

Github user asqasq commented on the issue:

    https://github.com/apache/incubator-crail/pull/64
  
    Thanks!


---

[GitHub] incubator-crail issue #64: [LICENSE] add licenses of dependencies

Posted by PepperJo <gi...@git.apache.org>.

Github user PepperJo commented on the issue:

    https://github.com/apache/incubator-crail/pull/64
  
    Makes sense. I will change it accordingly.


---

[GitHub] incubator-crail pull request #64: [LICENSE] add licenses of dependencies

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-crail/pull/64


---

[GitHub] incubator-crail issue #64: [LICENSE] add licenses of dependencies

Posted by asqasq <gi...@git.apache.org>.

Github user asqasq commented on the issue:

    https://github.com/apache/incubator-crail/pull/64
  
    Hi Jonas
    
    A minor comment: Since the license directory contains several licenses,
    we could rename the directory to licenses. This would also be consistent
    with other jars containing a licenses directory. It would also help in case
    that someone has a case-insensitive filesystem (LICENSE vs. licenses is fine,
    while LICENSE vs. license might not work).
    
    Otherwise looks good.



---