You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2017/05/01 16:54:02 UTC

mesos git commit: Bumped the default timeout value for docker volume detach operation.

Repository: mesos
Updated Branches:
  refs/heads/master 68ddce414 -> 2b427c788


Bumped the default timeout value for docker volume detach operation.

A volume detach operation can be very time consuming in some cloud
environment. In extreme cases, the detach can take up to 20 minutes.
Since 'Unmount' in Docker Volume Driver Interface (DVDI) is not
idempotent, the container orchestrator (i.e., Mesos) cannot safely
retry the operation. As a result, we don't have much flexibility here.
This patch increases the timeout value hoping the operation will
finish within this new timeout value in most of the cases.

Review: https://reviews.apache.org/r/58869


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2b427c78
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2b427c78
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2b427c78

Branch: refs/heads/master
Commit: 2b427c788d46747cc4abfb16138548dd389c60f1
Parents: 68ddce4
Author: Jie Yu <yu...@gmail.com>
Authored: Fri Apr 28 17:27:44 2017 -0700
Committer: Jie Yu <yu...@gmail.com>
Committed: Mon May 1 09:53:49 2017 -0700

----------------------------------------------------------------------
 src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/2b427c78/src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp b/src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp
index 18a8066..929b7e0 100644
--- a/src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp
+++ b/src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp
@@ -47,7 +47,7 @@ namespace docker {
 namespace volume {
 
 constexpr Duration MOUNT_TIMEOUT = Seconds(120);
-constexpr Duration UNMOUNT_TIMEOUT = Seconds(120);
+constexpr Duration UNMOUNT_TIMEOUT = Minutes(10);
 
 Try<Owned<DriverClient>> DriverClient::create(
     const string& dvdcli)