You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/04 08:40:08 UTC

[GitHub] [superset] villebro commented on pull request #18579: fix(sqla): avoid unnecessary groupby in samples request

villebro commented on pull request #18579:
URL: https://github.com/apache/superset/pull/18579#issuecomment-1029763401


   > LGTM ! nice to feel the value of chart data separated test suite!
   
   Agreed, the chart data test suite is a great tool to help harden the poorly tested sqla connector 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org