You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by bu...@apache.org on 2015/08/06 13:20:09 UTC

4.1.2_release_blocker requested: [Issue 126447] When using LanguageTools, toggling the checkbox "check grammar" in the spell checker removes content

Marcus <ma...@apache.org> has asked  for 4.1.2_release_blocker:
Issue 126447: When using LanguageTools, toggling the checkbox "check grammar"
in the spell checker removes content
https://bz.apache.org/ooo/show_bug.cgi?id=126447



--- Comment #1 from Marcus <ma...@apache.org> ---
@Stefan: Thanks for the patch. Seems to be an easy fix.

@All: I suggest to accept this issue and fix for the 4.1.2 release.

Reasons:
- Preventing data loss
- Easy fix
- Low risk
- Support the work from AOO contributors

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126447] When using LanguageTools, toggling the checkbox "check grammar" in the spell checker removes content

Posted by Marcus <ma...@wtnet.de>.
@Andrea:
As it is in your area to finally decide on issues for 4.1.2, what do you 
think?

Thanks

Marcus



Am 08/06/2015 01:20 PM, schrieb bugzilla@apache.org:
> Marcus<ma...@apache.org>  has asked  for 4.1.2_release_blocker:
> Issue 126447: When using LanguageTools, toggling the checkbox "check grammar"
> in the spell checker removes content
> https://bz.apache.org/ooo/show_bug.cgi?id=126447
>
>
>
> --- Comment #1 from Marcus<ma...@apache.org>  ---
> @Stefan: Thanks for the patch. Seems to be an easy fix.
>
> @All: I suggest to accept this issue and fix for the 4.1.2 release.
>
> Reasons:
> - Preventing data loss
> - Easy fix
> - Low risk
> - Support the work from AOO contributors

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126447] When using LanguageTools, toggling the checkbox "check grammar" in the spell checker removes content

Posted by Kay Schenk <ka...@gmail.com>.

On 08/30/2015 12:37 PM, Andrea Pescetti wrote:
> Kay Schenk wrote:
>> I did not encounter problems building with patch version 2.6, so I never
>> applied this patch. I'm rebuilding now to see if the patch works OK for
>> me. More feedback later today.
> 
> You surely meant the other thread/issue:
> https://bz.apache.org/ooo/show_bug.cgi?id=126258
> 
> and indeed the release notes I linked state that the behavior changed
> with GNU Patch 2.7. If we have confirmation that GNU Patch 2.6 still
> works (which I'm confident it does) with the patch, very good. We may
> want to note this in the issues.
> 
> Regards,
>   Andrea.

oops! yes. :(


-- 
--------------------------------------------
MzK

“The journey of a thousand miles begins
 with a single step.”
                          --Lao Tzu



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126447] When using LanguageTools, toggling the checkbox "check grammar" in the spell checker removes content

Posted by Andrea Pescetti <pe...@apache.org>.
Kay Schenk wrote:
> I did not encounter problems building with patch version 2.6, so I never
> applied this patch. I'm rebuilding now to see if the patch works OK for
> me. More feedback later today.

You surely meant the other thread/issue:
https://bz.apache.org/ooo/show_bug.cgi?id=126258

and indeed the release notes I linked state that the behavior changed 
with GNU Patch 2.7. If we have confirmation that GNU Patch 2.6 still 
works (which I'm confident it does) with the patch, very good. We may 
want to note this in the issues.

Regards,
   Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126447] When using LanguageTools, toggling the checkbox "check grammar" in the spell checker removes content

Posted by Kay Schenk <ka...@gmail.com>.

On 08/30/2015 08:42 AM, Andrea Pescetti wrote:
> On 06/08/2015 bugzilla wrote:
>> Marcus has asked  for 4.1.2_release_blocker:
>> Issue 126447: When using LanguageTools, toggling the checkbox "check
>> grammar"
>> in the spell checker removes content
>> https://bz.apache.org/ooo/show_bug.cgi?id=126447
> 
> This is committed to trunk, not yet to AOO410 (OpenOffice 4.1.2), but I
> plan to commit it if we have enough testing coverage. See issue for
> technical discussion.
> 
> Regards,
>   Andrea.

I did not encounter problems building with patch version 2.6, so I never
applied this patch. I'm rebuilding now to see if the patch works OK for
me. More feedback later today.


-- 
--------------------------------------------
MzK

“The journey of a thousand miles begins
 with a single step.”
                          --Lao Tzu



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126447] When using LanguageTools, toggling the checkbox "check grammar" in the spell checker removes content

Posted by Marcus <ma...@wtnet.de>.
Am 08/30/2015 05:42 PM, schrieb Andrea Pescetti:
> On 06/08/2015 bugzilla wrote:
>> Marcus has asked for 4.1.2_release_blocker:
>> Issue 126447: When using LanguageTools, toggling the checkbox "check
>> grammar"
>> in the spell checker removes content
>> https://bz.apache.org/ooo/show_bug.cgi?id=126447
>
> This is committed to trunk, not yet to AOO410 (OpenOffice 4.1.2), but I
> plan to commit it if we have enough testing coverage. See issue for
> technical discussion.

OK, thats fine.

Marcus


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126447] When using LanguageTools, toggling the checkbox "check grammar" in the spell checker removes content

Posted by Andrea Pescetti <pe...@apache.org>.
On 06/08/2015 bugzilla wrote:
> Marcus has asked  for 4.1.2_release_blocker:
> Issue 126447: When using LanguageTools, toggling the checkbox "check grammar"
> in the spell checker removes content
> https://bz.apache.org/ooo/show_bug.cgi?id=126447

This is committed to trunk, not yet to AOO410 (OpenOffice 4.1.2), but I 
plan to commit it if we have enough testing coverage. See issue for 
technical discussion.

Regards,
   Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org