You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/07/15 11:59:40 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM with same...
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/594
CLOUDSTACK-8637: Verify that VM with same Display name creation fails if vm.instancename.flag=true
When vm.instancename.flag=true it will only set the "instancename" without any additional prefix so name of the instance on host will also be same hence verify that when tried to create another instance with same name on same host should fail on VMWare as it should have every instance with unique name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-8637-Verify-that-cloudstack-gives-error-on-creation-of-VMs-with-the-same-Display-name-when-vm.instancename.flag=true
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/594.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #594
----
commit a2df28d2f7f2596a121a53ee064250b62bb3b6c2
Author: Priti Sarap <pr...@clogeny.com>
Date: 2015-07-15T09:46:24Z
CLOUDSTACK-8637: Verify that VM with same Display name creation fails if vm.instancename.flag=true
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM with same...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM with same...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/594#issuecomment-121601522
looks like this is for vmware only
no way for me to verify, but good looks okay.
LGTM, merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM
with same...
Posted by Sanjeev N <sa...@apache.org>.
LGTM
On Wed, Jul 15, 2015 at 3:29 PM, pritisarap12 <gi...@git.apache.org> wrote:
> GitHub user pritisarap12 opened a pull request:
>
> https://github.com/apache/cloudstack/pull/594
>
> CLOUDSTACK-8637: Verify that VM with same Display name creation fails
> if vm.instancename.flag=true
>
> When vm.instancename.flag=true it will only set the "instancename"
> without any additional prefix so name of the instance on host will also be
> same hence verify that when tried to create another instance with same name
> on same host should fail on VMWare as it should have every instance with
> unique name.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pritisarap12/cloudstack
> CLOUDSTACK-8637-Verify-that-cloudstack-gives-error-on-creation-of-VMs-with-the-same-Display-name-when-vm.instancename.flag=true
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/594.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #594
>
> ----
> commit a2df28d2f7f2596a121a53ee064250b62bb3b6c2
> Author: Priti Sarap <pr...@clogeny.com>
> Date: 2015-07-15T09:46:24Z
>
> CLOUDSTACK-8637: Verify that VM with same Display name creation fails
> if vm.instancename.flag=true
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>