[GitHub] [airflow] turbaszek commented on a change in pull request #11185: Add LegacyUIDeprecated rule and unittests

[GitBox <gi...@apache.org>]

turbaszek commented on a change in pull request #11185:
URL: https://github.com/apache/airflow/pull/11185#discussion_r498473593



##########
File path: airflow/upgrade/rules/legacy_ui_deprecated.py
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import absolute_import
+
+from airflow.configuration import conf
+from airflow.upgrade.rules.base_rule import BaseRule
+
+
+class LegacyUIDeprecatedRule(BaseRule):
+    title = "RBAC is enabled by default"
+
+    description = "Legacy UI is deprecated. FAB RBAC is enabled by default in order to increase security."
+
+    def check(self):
+        rbac_conf = conf.getboolean("webserver", "rbac")
+        if not rbac_conf:
+            msg = """rbac in airflow.cfg must be explicitly set empty as RBAC mechanism is enabled by default. """

Review comment:
       ```suggestion
               msg = "rbac in airflow.cfg must be explicitly set empty as RBAC mechanism is enabled by default. "
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org