You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tengpeng <gi...@git.apache.org> on 2017/10/29 01:25:02 UTC
[GitHub] spark pull request #19600: Added more information to Imputer
GitHub user tengpeng opened a pull request:
https://github.com/apache/spark/pull/19600
Added more information to Imputer
Often times we want to impute custom values other than 'NaN'. My addition helps people locate this function without reading the API.
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tengpeng/spark patch-5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19600
----
commit 2350fc1de3eaa0a3aafd7aba11c5d99b39d4c606
Author: tengpeng <te...@users.noreply.github.com>
Date: 2017-10-29T01:24:38Z
Added more information to Imputer
Often times we want to impute custom values other than 'NaN'. My addition helps people locate this function without reading the API.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19600: Added more information to Imputer
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19600
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19600: Added more information to Imputer
Posted by tengpeng <gi...@git.apache.org>.
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/19600
I will follow the guideline strictly next time. Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19600: Added more information to Imputer
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19600
**[Test build #3963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3963/testReport)** for PR 19600 at commit [`2350fc1`](https://github.com/apache/spark/commit/2350fc1de3eaa0a3aafd7aba11c5d99b39d4c606).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19600: Added more information to Imputer
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19600
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19600: Added more information to Imputer
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19600
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19600: Added more information to Imputer
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19600
**[Test build #3963 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3963/testReport)** for PR 19600 at commit [`2350fc1`](https://github.com/apache/spark/commit/2350fc1de3eaa0a3aafd7aba11c5d99b39d4c606).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org