[GitHub] [zeppelin] Reamer commented on pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5

["Reamer (via GitHub)" <gi...@apache.org>]

Reamer commented on PR #4559:
URL: https://github.com/apache/zeppelin/pull/4559#issuecomment-1449891496

   > I just have a very small question about this: I noticed that you removed the `public` modifier from the `@Test` method but retain the `public` modifier for methods that are decorated by `@BeforEeach` .
   > 
   > Is there any special purpose in this?
   
   There is no deeper meaning. My IDE runs the sonarlint plugin, this plugin gives me a little hint to remove the public modifier.
   https://rules.sonarsource.com/java/RSPEC-5786
   
   Unfortunately the hint is missing for @BeforeEach and other methods, so I overlooked deleting the modifier at this point.
   
   I will go back through the test classes and remove the visibility.
   
   JUnit5 recommends removing the public modifier.
   https://junit.org/junit5/docs/current/user-guide/#writing-tests-classes-and-methods


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org