[jira] [Comment Edited] (MADLIB-1077) Double check binary distribution

["Frank McQuillan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MADLIB-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901729#comment-15901729 ] 

Frank McQuillan edited comment on MADLIB-1077 at 3/8/17 7:53 PM:
-----------------------------------------------------------------

Upon review, I think the binaries look OK from a license perspective.

(1) PyXB: Python XML Schema Bindings
http://pyxb.sourceforge.net/

http://pyxb.sourceforge.net/legal.html
says
“PyXB as a whole is made available under the Apache License v 2.0.”
See also
https://github.com/pabigot/pyxb/blob/next/LICENSE
which has the standard Apache License Version 2.0 verbage.

However, we noticed that it has a GPL 3.0 sub-component:
https://github.com/pabigot/pyxb/blob/next/doc/extapi.py
(This seems strange, but anyways…)

Remedy from Sept 2015:  
* At build time, we remove this GPL sub-component since it is not needed,
just to be 100% sure we are only including Apache License Version 2.0 software.  
* This is the reason there is a message during build that says “PyXB: Removing GPL component from code base”


(2) Eigen
http://eigen.tuxfamily.org/

http://eigen.tuxfamily.org/index.php?title=Main_Page#License
says
“Eigen is Free Software. Starting from the 3.1.1 version, it is licensed under the MPL2…Note that currently, a few features rely on third-party code licensed under the LGPL: SimplicialCholesky, AMD ordering, and constrained_cg.”  

MADlib uses a later version than 3.1.1.

Remedy from Sept 2015, as per Roman's guidance at that time and as per http://www.apache.org/legal/resolved.html#category-b:
* Cloned Eigen header files and made needed changes, then maintained on a separate GitHub repo https://github.com/madlib/eigen
* This modified Eigen GitHub project carries forward the MPL license
* At build time, MADlib project will then include the Eigen header files from this repo
* Also we use the EIGEN_MPL2_ONLY preprocessor symbol to explicitly exclude the LGPL components




was (Author: fmcquillan):
Upon review, I think the binaries look OK from a license perspective.

(1) PyXB: Python XML Schema Bindings
http://pyxb.sourceforge.net/

http://pyxb.sourceforge.net/legal.html
says
“PyXB as a whole is made available under the Apache License v 2.0.”
See also
https://github.com/pabigot/pyxb/blob/next/LICENSE
which has the standard Apache License Version 2.0 verbage.

However, we noticed that it has a GPL 3.0 sub-component:
https://github.com/pabigot/pyxb/blob/next/doc/extapi.py
(This seems strange, but anyways…)

Remedy from Sept 2015:  
* At build time, we remove this GPL sub-component since it is not needed,
just to be 100% sure we are only including Apache License Version 2.0 software.  
* This is the reason there is a message during build that says “PyXB: Removing GPL component from code base”


(2) Eigen
http://eigen.tuxfamily.org/

http://eigen.tuxfamily.org/index.php?title=Main_Page#License
says
“Eigen is Free Software. Starting from the 3.1.1 version, it is licensed under the MPL2…Note that currently, a few features rely on third-party code licensed under the LGPL: SimplicialCholesky, AMD ordering, and constrained_cg.”  

MADlib uses a later version than 3.1.1.

Remedy from Sept 2015, as per Roman's guidance at that time and as per http://www.apache.org/legal/resolved.html#category-b:
* Cloned Eigen header files and made needed changes, then maintained on a separate GitHub repo https://github.com/madlib/eigen
* This modified Eigen GitHub project carries forward the MPL license
* At build time, MADlib project will then include the Eigen header files from this repo



> Double check binary distribution
> --------------------------------
>
>                 Key: MADLIB-1077
>                 URL: https://issues.apache.org/jira/browse/MADLIB-1077
>             Project: Apache MADlib
>          Issue Type: Task
>          Components: All Modules
>            Reporter: Frank McQuillan
>             Fix For: v1.11
>
>
> Double check that binary distribution licensing issues are all OK.
> For example, see comments from Ed Espino on 1.10 RC-2 review on thread
> https://mail-archives.apache.org/mod_mbox/incubator-madlib-user/201703.mbox/%3CCAHAuQDzarS7K4u-rOsLLhbwSHCyFn5cKSyjLinE%2BZ%3DjSpU59qw%40mail.gmail.com%3E
> {code}
>  I was performing the build from a simple perspective. Download
>   source, configure, make and glance at docs (in this order).
>   As we have dealt with auto-downloaded files in the HAWQ project, I
>   was a surprised that the following packages were automatically
>   downloaded for me. On the HAWQ project we were instructed to require
>   these as pre-requisites and or make them optional included via
>   command line options (configure).  I'm guessing other packages would
>   have been automatically downloaded if they were not found on system
>   (eg: boost).
>   Automatically downloaded packages:
>       https://github.com/madlib/eigen/archive/branches/3.2.tar.gz
>       http://sourceforge.net/projects/pyxb/files/PyXB-1.2.4.tar.gz
>   
> Issue: As "make" was running, the following message was a bit alarming:
>        PyXB: Removing GPL component from code base
>   
>     This comes from the script src/patch/PyXB.sh run after PyXB source
>     is downloaded.
>     
>       ...
>       echo "PyXB: Removing GPL component from code base"
>       rm -f doc/extapi.py
>       rm -f doc/extapi.pyc
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)