You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/22 18:22:45 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new issue #5556: CiaB: TO test and TP test no longer unset DIG_IP_RETRY and LOAD_TRAFFIC_OPS_DATA
zrhoffman opened a new issue #5556:
URL: https://github.com/apache/trafficcontrol/issues/5556
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- CDN in a Box
- CI tests
## Current behavior:
<!-- Describe how the bug manifests -->
apache/trafficcontrol#5209 removed the parts of `docker-compose.traffic-ops-test.yml` and `docker-compose.traffic-portal-test.yml` that unset `DIG_IP_RETRY` and `LOAD_TRAFFIC_OPS_DATA` for the `trafficops-perl` service:
```diff
diff --git a/infrastructure/cdn-in-a-box/docker-compose.traffic-ops-test.yml b/infrastructure/cdn-in-a-box/docker-compose.traffic-ops-test.yml
index 2093e8ad18..02bc077566 100644
--- a/infrastructure/cdn-in-a-box/docker-compose.traffic-ops-test.yml
+++ b/infrastructure/cdn-in-a-box/docker-compose.traffic-ops-test.yml
@@ -19,8 +19,8 @@
# there is already a trafficops docker instance. When using docker,
# make sure any container rpms you need are updated. Below is an
# example of how to run the main compose with this file:
-#
-# docker-compose up --build db trafficops-perl trafficops
+#
+# docker-compose up --build db trafficops
# docker-compose -f docker-compose.traffic-ops-test.yml up --build integration
---
@@ -39,11 +39,6 @@ services:
- shared:/shared
- ../../junit:/junit
- trafficops-perl:
- environment:
- DIG_IP_RETRY: ${DIG_IP_RETRY:-0}
- LOAD_TRAFFIC_OPS_DATA: ${LOAD_TRAFFIC_OPS_DATA:-false}
-
volumes:
junit:
shared:
diff --git a/infrastructure/cdn-in-a-box/docker-compose.traffic-portal-test.yml b/infrastructure/cdn-in-a-box/docker-compose.traffic-portal-test.yml
index 6cfb84842b..f7eadbb0f8 100644
--- a/infrastructure/cdn-in-a-box/docker-compose.traffic-portal-test.yml
+++ b/infrastructure/cdn-in-a-box/docker-compose.traffic-portal-test.yml
@@ -19,8 +19,8 @@
# there is already a trafficportal docker instance. When using docker,
# make sure any container rpms you need are updated. Below is an
# example of how to run the main compose with this file:
-#
-# docker-compose up --build db trafficops trafficops-perl trafficportal
+#
+# docker-compose up --build db trafficops trafficportal
# docker-compose -f docker-compose.traffic-portal-test.yml up --build
---
@@ -43,10 +43,6 @@ services:
- shared:/shared
- ../../junit:/junit
- trafficops-perl:
- environment:
- DIG_IP_RETRY: ${DIG_IP_RETRY:-0}
-
volumes:
shared:
external: false
```
## Expected behavior:
<!-- Describe what the behavior would be without the bug -->
Since the `trafficop` service now runs `load_data_from()` and `set-to-ips-from-dns.sh` instead of `trafficops-perl`, those lines should be kept but the service name changed to `trafficops`.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
include the applicable TC version.
-->
### For the TO API Tests:
```shell
docker-compose -f docker-compose.yml -f docker-compose.traffic-ops-test.yml --no-ansi up --no-deps -d edge enroller dns db smtp trafficops-perl trafficops trafficvault integration
```
### For the TP UI Tests:
```shell
docker-compose -f docker-compose.yml -f docker-compose.traffic-portal-test.yml --no-ansi up -d db edge trafficops-perl trafficportal trafficops trafficvault portal-integration-test
```
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp closed issue #5556: CiaB: TO test and TP test no longer unset DIG_IP_RETRY and LOAD_TRAFFIC_OPS_DATA
Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #5556:
URL: https://github.com/apache/trafficcontrol/issues/5556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org