You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/02/25 09:11:23 UTC
[GitHub] [arrow-datafusion] jackwener opened a new issue, #5396: in `tpcds_logical_q58`
jackwener opened a new issue, #5396:
URL: https://github.com/apache/arrow-datafusion/issues/5396
**Describe the bug**
after disable `skip_failed_rules`.
tpcds_logical_q58 failed in
'simplify_expressions' failed due to unexpected error: Arrow error: Compute error: Overflow happened on: 100 * 100000000000000000000000000000000000000"
**To Reproduce**
Steps to reproduce the behavior:
**Expected behavior**
A clear and concise description of what you expected to happen.
**Additional context**
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `Compute error: Overflow happened` in `tpcds_logical_q58` [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed issue #5396: `Compute error: Overflow happened` in `tpcds_logical_q58`
URL: https://github.com/apache/datafusion/issues/5396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org
Re: [I] `Compute error: Overflow happened` in `tpcds_logical_q58` [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #5396:
URL: https://github.com/apache/datafusion/issues/5396#issuecomment-2067820012
`skip_failed_rules` is now disabled by default by #6265
https://github.com/apache/datafusion/blob/19356b26f515149f96f9b6296975a77ac7260149/datafusion/common/src/config.rs#L546-L549
And `tpcds_logical_q58` is not ignored and runs successfully in test suite:
https://github.com/apache/datafusion/blob/19356b26f515149f96f9b6296975a77ac7260149/datafusion/core/tests/tpcds_planning.rs#L319-L322
Closing issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org
[GitHub] [arrow-datafusion] jackwener commented on issue #5396: `Compute error: Overflow happened` in `tpcds_logical_q58`
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on issue #5396:
URL: https://github.com/apache/arrow-datafusion/issues/5396#issuecomment-1450354581
failed in `"CAST(Int64(100) AS Decimal128(38, 38))"`
`"ArrowError(ComputeError("Overflow happened on: 100 * 100000000000000000000000000000000000000"))"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on issue #5396: `Compute error: Overflow happened` in `tpcds_logical_q58`
Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.
HaoYang670 commented on issue #5396:
URL: https://github.com/apache/arrow-datafusion/issues/5396#issuecomment-1445038628
> After we fix this problem, we can disable skip_failed_rules
This is really a great news! Great works @jackwener.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on issue #5396: `Compute error: Overflow happened` in `tpcds_logical_q58`
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on issue #5396:
URL: https://github.com/apache/arrow-datafusion/issues/5396#issuecomment-1445038395
cc @HaoYang670 .
After we fix this problem, we can disable `skip_failed_rules `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on issue #5396: `Compute error: Overflow happened` in `tpcds_logical_q58`
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #5396:
URL: https://github.com/apache/arrow-datafusion/issues/5396#issuecomment-1456565401
> failed in expression "CAST(Int64(100) AS Decimal128(38, 38))"
This sounds like a type inference bug, as opposed to something related to the handling of decimal arithmetic. In particular where has this scale of 38 come from? Such a datatype cannot represent anything greater 1 and so the query is perfectly correct to bail out with an error.
The original schema has a precision of 2, as it represents a monetary quantity, and so ending up with a scale of 38 is extremely suspect...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on issue #5396: in `tpcds_logical_q58`
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on issue #5396:
URL: https://github.com/apache/arrow-datafusion/issues/5396#issuecomment-1445037502
I investigated it, I found bug in `ConstEvaluator`.
It will failed in `expr.rewrite(&mut const_evaluator)?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya commented on issue #5396: `Compute error: Overflow happened` in `tpcds_logical_q58`
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #5396:
URL: https://github.com/apache/arrow-datafusion/issues/5396#issuecomment-1450458198
We've dealt with such issue in [#3690](https://github.com/apache/arrow-rs/pull/3690).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org