[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #21789: fix issue: startup application with springboot failed when no rules config.

[GitBox <gi...@apache.org>]

strongduanmu commented on code in PR #21789:
URL: https://github.com/apache/shardingsphere/pull/21789#discussion_r1006510507


##########
jdbc/spring/core/spring-boot-starter/src/main/java/org/apache/shardingsphere/spring/boot/rule/LocalRulesCondition.java:
##########
@@ -24,16 +24,16 @@
 import org.springframework.core.type.AnnotatedTypeMetadata;
 
 /**
- * Local rules condition.
+ * Local configuration condition.
  */
 public final class LocalRulesCondition extends SpringBootCondition {

Review Comment:
   Can you rename LocalRulesCondition to ShardingSphereSpringBootCondition? Now this class is not related to rules.



##########
jdbc/spring/core/spring-boot-starter/src/main/java/org/apache/shardingsphere/spring/boot/rule/LocalRulesCondition.java:
##########
@@ -24,16 +24,16 @@
 import org.springframework.core.type.AnnotatedTypeMetadata;
 
 /**
- * Local rules condition.
+ * Local configuration condition.
  */
 public final class LocalRulesCondition extends SpringBootCondition {
     
-    private static final String SHARDING_PREFIX = "spring.shardingsphere.rules";
+    private static final String SHARDING_PREFIX = "spring.shardingsphere";

Review Comment:
   Please add unit test for this logic change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org