[GitHub] [ozone] adoroszlai commented on a change in pull request #2947: HDDS-6114. Intermittent error due to Failed to init RocksDB

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #2947:
URL: https://github.com/apache/ozone/pull/2947#discussion_r782911199



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneHAClusterImpl.java
##########
@@ -673,25 +708,19 @@ private void initOMHAConfig(int basePort) throws IOException {
           OMConfigKeys.OZONE_OM_NODES_KEY, omServiceId);
       List<String> omNodeIds = new ArrayList<>();
 
-      int port = basePort;
+      omPorts.reserve(numOfOMs);
+      ReservedPorts omRpcPorts = new ReservedPorts(1);
+      omRpcPorts.reserve(numOfOMs);

Review comment:
       RPC endpoints are started in methods called from `OzoneManager` and `StorageContainerManager` constructors.  So we need to release these RPC ports earlier than those for services really started in `start()`.  We still reserve them at the same time as the other ports to avoid conflicts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org