You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by vieiro <gi...@git.apache.org> on 2017/10/03 10:50:19 UTC
[GitHub] incubator-netbeans pull request #46: Updating the rat exclusion list
GitHub user vieiro opened a pull request:
https://github.com/apache/incubator-netbeans/pull/46
Updating the rat exclusion list
Now excluding the following automatically generated files from the rat report:
- **/nbproject/build-impl.xml
- **/nbproject/jfx-impl.xml
- **/nbproject/genfiles.properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vieiro/incubator-netbeans netbeans-54-module-review-nbbuild
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit 40a715ad91e47696a8018c48c7ad091b9c4341ec
Author: Antonio Vieiro <an...@vieiro.net>
Date: 2017-10-03T10:45:10Z
Updating the rat exclusion list
Now excluding the following automatically generated files from the rat report:
- **/nbproject/build-impl.xml
- **/nbproject/jfx-impl.xml
- **/nbproject/genfiles.properties
----
---
[GitHub] incubator-netbeans pull request #46: Updating the rat exclusion list
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/46
---
[GitHub] incubator-netbeans issue #46: Updating the rat exclusion list
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/46
One additional thing I'd add is:
- `*/nbproject/private/**` (the files are per user and should not be distributed)
I would also not match with `**/nbproject` but `*/nbproject`. This way you wont accidentally match wrong files.
---
[GitHub] incubator-netbeans issue #46: Updating the rat exclusion list
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/46
Merged - thank you.
---
[GitHub] incubator-netbeans issue #46: Updating the rat exclusion list
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/46
Looks good - the files that would match also look clean (either ALv2 or no license header):
```
matthias@athena:~/src/incubator-netbeans$ find . \( -name build-impl.xml -o -name jfx-impl.xml -o -name genfiles.properties \) -print0 | xargs -0 grep -i CDDL
matthias@athena:~/src/incubator-netbeans$ find . \( -name build-impl.xml -o -name jfx-impl.xml -o -name genfiles.properties \) -print0 | xargs -0 grep -i LICENSE
./java.examples/anagrams/nbproject/genfiles.properties:# Licensed to the Apache Software Foundation (ASF) under one
./java.examples/anagrams/nbproject/genfiles.properties:# or more contributor license agreements. See the NOTICE file
./java.examples/anagrams/nbproject/genfiles.properties:# regarding copyright ownership. The ASF licenses this file
./java.examples/anagrams/nbproject/genfiles.properties:# to you under the Apache License, Version 2.0 (the
./java.examples/anagrams/nbproject/genfiles.properties:# "License"); you may not use this file except in compliance
./java.examples/anagrams/nbproject/genfiles.properties:# with the License. You may obtain a copy of the License at
./java.examples/anagrams/nbproject/genfiles.properties:# http://www.apache.org/licenses/LICENSE-2.0
./java.examples/anagrams/nbproject/genfiles.properties:# software distributed under the License is distributed on an
./java.examples/anagrams/nbproject/genfiles.properties:# KIND, either express or implied. See the License for the
./java.examples/anagrams/nbproject/genfiles.properties:# under the License.
./nbi/engine/nbproject/genfiles.properties:# Licensed to the Apache Software Foundation (ASF) under one
./nbi/engine/nbproject/genfiles.properties:# or more contributor license agreements. See the NOTICE file
./nbi/engine/nbproject/genfiles.properties:# regarding copyright ownership. The ASF licenses this file
./nbi/engine/nbproject/genfiles.properties:# to you under the Apache License, Version 2.0 (the
./nbi/engine/nbproject/genfiles.properties:# "License"); you may not use this file except in compliance
./nbi/engine/nbproject/genfiles.properties:# with the License. You may obtain a copy of the License at
./nbi/engine/nbproject/genfiles.properties:# http://www.apache.org/licenses/LICENSE-2.0
./nbi/engine/nbproject/genfiles.properties:# software distributed under the License is distributed on an
./nbi/engine/nbproject/genfiles.properties:# KIND, either express or implied. See the License for the
./nbi/engine/nbproject/genfiles.properties:# under the License.
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: Licensed to the Apache Software Foundation (ASF) under one
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: or more contributor license agreements. See the NOTICE file
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: regarding copyright ownership. The ASF licenses this file
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: to you under the Apache License, Version 2.0 (the
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: "License"); you may not use this file except in compliance
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: with the License. You may obtain a copy of the License at
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: http://www.apache.org/licenses/LICENSE-2.0
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: software distributed under the License is distributed on an
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: KIND, either express or implied. See the License for the
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml: under the License.
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: Licensed to the Apache Software Foundation (ASF) under one
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: or more contributor license agreements. See the NOTICE file
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: regarding copyright ownership. The ASF licenses this file
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: to you under the Apache License, Version 2.0 (the
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: "License"); you may not use this file except in compliance
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: with the License. You may obtain a copy of the License at
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: http://www.apache.org/licenses/LICENSE-2.0
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: software distributed under the License is distributed on an
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: KIND, either express or implied. See the License for the
./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml: under the License.
```
---