[GitHub] [guacamole-client] necouchman commented on a diff in pull request #734: GUACAMOLE-1611: Update French translations.

[GitBox <gi...@apache.org>]

necouchman commented on code in PR #734:
URL: https://github.com/apache/guacamole-client/pull/734#discussion_r891219315


##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -4,14 +4,18 @@
 
     "APP" : {
 
+        "NAME"    : "Apache Guacamole",
+        "VERSION" : "${project.version}",

Review Comment:
   These two items should not be re-defined in the non-English translation.



##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/translations/fr.json:
##########
@@ -1,7 +1,26 @@
 {
 
+    "DATA_SOURCE_CAS" : {
+        "NAME" : "CAS SSO Backend"
+    },
+
+    "DATA_SOURCE_OPENID" : {
+        "NAME" : "OpenID SSO Backend"
+    },
+
+    "DATA_SOURCE_SAML" : {
+        "NAME" : "SAML SSO Backend"
+    },
+
     "LOGIN" : {
-        "INFO_IDP_REDIRECT_PENDING" : "Veuillez patienter, redirection vers le fournisseur d'identité..."
+        "FIELD_HEADER_ID_TOKEN"      : "",
+        "FIELD_HEADER_STATE"         : "",
+        "FIELD_HEADER_TICKET"        : "",

Review Comment:
   You can leave out empty strings.



##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -207,7 +215,7 @@
 
         "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
 
-        "ERROR_INVALID_LOGIN" : "Identifiant Incorrect",
+        "ERROR_INVALID_LOGIN" : "Identifiant ou mot de passe incorrect",

Review Comment:
   I'm not sure that this should be translated to an invalid password - this may not always be a password failure. For example, if you are using SSO, Duo, or TOTP, the login failure could occur in something other than a user password. This may be misleading??



##########
extensions/guacamole-auth-ldap/src/main/resources/translations/fr.json:
##########
@@ -0,0 +1,7 @@
+{
+
+    "DATA_SOURCE_LDAP" : {
+        "NAME" : "LDAP"

Review Comment:
   Same, here - is this the French translation, or just a copy of the English one?



##########
extensions/guacamole-auth-json/src/main/resources/translations/fr.json:
##########
@@ -0,0 +1,7 @@
+{
+
+    "DATA_SOURCE_JSON" : {
+        "NAME" : "JSON"

Review Comment:
   Is this the correct French translation for this? Or just a copy of the English translation?



##########
extensions/guacamole-auth-radius/src/main/resources/translations/fr.json:
##########
@@ -0,0 +1,13 @@
+{
+
+    "DATA_SOURCE_RADIUS" : {
+        "NAME" : "RADIUS Backend"
+    },
+
+    "LOGIN" : {
+        "FIELD_HEADER_GUAC_RADIUS_CHALLENGE_RESPONSE" : "",
+        "FIELD_HEADER_GUAC_RADIUS_STATE"              : "",

Review Comment:
   No need to include empty translations.



##########
extensions/guacamole-auth-radius/src/main/resources/translations/fr.json:
##########
@@ -0,0 +1,13 @@
+{
+
+    "DATA_SOURCE_RADIUS" : {
+        "NAME" : "RADIUS Backend"

Review Comment:
   Is this the correct French translation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org