You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/13 14:29:17 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9133:
[config] Disable FAB's permission and view menus views
dpgaspar opened a new pull request #9133: [config] Disable FAB's permission and view menus views
URL: https://github.com/apache/incubator-superset/pull/9133
### CATEGORY
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Disable FAB's permission view and views view from the security menu
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9133: [config]
Disable FAB's permission and view menus views
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9133: [config] Disable FAB's permission and view menus views
URL: https://github.com/apache/incubator-superset/pull/9133#issuecomment-588172869
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=h1) Report
> Merging [#9133](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/20eff09d7290cfab032807ad3b1f94787a14bf32?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9133 +/- ##
==========================================
- Coverage 59.11% 59.08% -0.04%
==========================================
Files 372 372
Lines 11926 11926
Branches 2919 2920 +1
==========================================
- Hits 7050 7046 -4
- Misses 4694 4698 +4
Partials 182 182
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/components/MissingChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9133/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL01pc3NpbmdDaGFydC5qc3g=) | `100% <ø> (ø)` | :arrow_up: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9133/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `91.78% <100%> (+0.47%)` | :arrow_up: |
| [superset-frontend/src/components/Loading.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9133/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy5qc3g=) | `55.55% <0%> (-44.45%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=footer). Last update [20eff09...f3b310c](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9133:
[config] Disable FAB's permission and view menus views
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9133: [config] Disable FAB's permission and view menus views
URL: https://github.com/apache/incubator-superset/pull/9133#issuecomment-588172869
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=h1) Report
> Merging [#9133](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3b310c3e96555dcba48f481691dfb3ec563b8c7?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9133 +/- ##
==========================================
+ Coverage 59.08% 59.16% +0.08%
==========================================
Files 372 372
Lines 11926 11935 +9
Branches 2920 2927 +7
==========================================
+ Hits 7046 7061 +15
+ Misses 4698 4694 -4
+ Partials 182 180 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9133/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0% <ø> (ø)` | :arrow_up: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9133/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `91.66% <100%> (+0.75%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9133/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `93.54% <80%> (-6.46%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9133/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbmsudHN4) | `93.75% <93.75%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=footer). Last update [f3b310c...2e0b238](https://codecov.io/gh/apache/incubator-superset/pull/9133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #9133: [config]
Disable FAB's permission and view menus views
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #9133: [config] Disable FAB's permission and view menus views
URL: https://github.com/apache/incubator-superset/pull/9133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org