You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/20 07:49:11 UTC
[GitHub] [airflow] xylar opened a new issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
xylar opened a new issue #22380:
URL: https://github.com/apache/airflow/issues/22380
### Apache Airflow Provider(s)
ftp, openfaas, sqlite
### Versions of Apache Airflow Providers
I am the maintainer of the Airflow Providers on conda-forge. The providers I listed above are the first 3 I have looked at but I believe all are affected. These are the new releases (as of yesterday) of all providers.
### Apache Airflow version
2.2.4 (latest released)
### Operating System
Linux (Azure CI)
### Deployment
Other Docker-based deployment
### Deployment details
This is on conda-forge Azure CI.
### What happened
All providers I have looked at (and I suspect all providers) now have `gitpython` and `wheel` in their `install_requires`:
From `apache-airflow-providers-ftp-2.1.1.tar.gz`:
```
install_requires =
gitpython
wheel
```
I believe these requirements are incorrect (neither should be needed at install time) and this will make maintaining these packages on conda-forge an absolute nightmare! (It's already a serious challenge because I get a PR to update each time each provider gets updated.)
### What you think should happen instead
These install requirements should be removed.
### How to reproduce
Open any of the newly released providers from pypi and look at `setup.cfg`.
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1077348497
FYI in case you did not notice @xylar - we are voting on the packages with the fix Discussion here: https://lists.apache.org/thread/g990cb3vqkzq7jr3yvldy253wtt8vhnq and "test issue" in #22480.
Would be great if you could confirm that the RC packages look good for you as well (few of them that contains some other fixed are mentioned and linked from #22480).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073237237
BTW. Learning for myself - DO split changes and semi-automated documentation generation. This way the change could have been detected at code review time. The #22226 change was far too big to catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xylar commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
xylar commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1077573781
Yep, I took a look at several more and they also look good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1077580748
> Yep, I took a look at several more and they also look good.
Cool. Thanks for sparing another pair of eyes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xylar commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
xylar commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1077571731
Thank you! I agree that the the dependencies in `apache-airflow-providers-docker` 2.5.2rc1 look good. If the other providers are similar, we'll be in great shape!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xylar commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
xylar commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073235830
@potiuk, no worries on my side. I know I sounded pretty annoyed above. But this was the excuse I needed to automate my update process on conda-forge.
Sorry that it's going to be a bit of work for you, though. Thanks for taking care of it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xylar commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
xylar commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073192097
I believe this was added in https://github.com/apache/airflow/pull/22226, perhaps by mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1079560555
New providers released. They are all yours @xylar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073231426
Yep. This is my mistake indeed. I will have to rerelease all of the providers and yank all of them I am afraid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #22380:
URL: https://github.com/apache/airflow/issues/22380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1077352993
BTW. I compared (for example) https://pypi.org/pypi/apache-airflow-providers-docker/2.5.1/json with https://pypi.org/pypi/apache-airflow-providers-docker/2.5.2rc1/json so it **shoudl** be fine - but I think with your conda stuff you can check more :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073190760
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073236767
> Sorry that it's going to be a bit of work for you, though. Thanks for taking care of it!
No - no worries at all - thanks for reporting it so quickly @xylar actually. It slipeed my automation tests (for good reasons) and I have the releases mostly automated, so the work from my side is not as big as it might seem (highly recommend to add the automation indeed :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xylar commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
xylar commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1079735554
Thanks again. Most new providers should be should now be available from conda-forge. There were a few newer ones that I hadn't added recipes for yet. They're awaiting review (or review of missing dependencies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073220781
cc @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #22380:
URL: https://github.com/apache/airflow/issues/22380#issuecomment-1077352993
BTW. I compared (for example) https://pypi.org/pypi/apache-airflow-providers-docker/2.5.1/json with https://pypi.org/pypi/apache-airflow-providers-docker/2.5.2rc1/json so it **should** be fine - but I think with your conda stuff you can check more :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org