You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/06/02 18:53:16 UTC

Review Request 22146: Unit Testing Improvments : Examine TestPassFileGeneration.testPassFileGen

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22146/
-----------------------------------------------------------

Review request for Ambari and Tom Beerbower.


Bugs: AMBARI-5993
    https://issues.apache.org/jira/browse/AMBARI-5993


Repository: ambari


Description
-------

In an effort to reduce the amount of time it takes to run the unit tests we should examine slowest of them and see if we can make improvements through the use of mocks or common setup or something else.
This is one of the slowest ...
12.004torg.apache.ambari.server.security.TestPassFileGeneration.testPassFileGen


Diffs
-----

  ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 45ced24 
  ambari-server/src/test/java/org/apache/ambari/server/security/TestPassFileGeneration.java dc35e5d 

Diff: https://reviews.apache.org/r/22146/diff/


Testing
-------

[INFO] Ambari Main ....................................... SUCCESS [1.844s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.268s]
[INFO] Ambari Web ........................................ SUCCESS [9.978s]
[INFO] Ambari Views ...................................... SUCCESS [2.308s]
[INFO] Ambari Server ..................................... SUCCESS [13:22.239s]
[INFO] Ambari Agent ...................................... SUCCESS [5.066s]
[INFO] Ambari Client ..................................... SUCCESS [0.041s]
[INFO] Ambari Python Client .............................. SUCCESS [0.486s]
[INFO] Ambari Groovy Client .............................. SUCCESS [3.724s]
[INFO] Ambari Shell ...................................... SUCCESS [4.282s]


Thanks,

Dmytro Sen


Re: Review Request 22146: Unit Testing Improvments : Examine TestPassFileGeneration.testPassFileGen

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22146/#review44537
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On June 2, 2014, 4:53 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22146/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 4:53 p.m.)
> 
> 
> Review request for Ambari and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5993
>     https://issues.apache.org/jira/browse/AMBARI-5993
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In an effort to reduce the amount of time it takes to run the unit tests we should examine slowest of them and see if we can make improvements through the use of mocks or common setup or something else.
> This is one of the slowest ...
> 12.004torg.apache.ambari.server.security.TestPassFileGeneration.testPassFileGen
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 45ced24 
>   ambari-server/src/test/java/org/apache/ambari/server/security/TestPassFileGeneration.java dc35e5d 
> 
> Diff: https://reviews.apache.org/r/22146/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Ambari Main ....................................... SUCCESS [1.844s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.268s]
> [INFO] Ambari Web ........................................ SUCCESS [9.978s]
> [INFO] Ambari Views ...................................... SUCCESS [2.308s]
> [INFO] Ambari Server ..................................... SUCCESS [13:22.239s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.066s]
> [INFO] Ambari Client ..................................... SUCCESS [0.041s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.486s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [3.724s]
> [INFO] Ambari Shell ...................................... SUCCESS [4.282s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>