You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/02 09:25:48 UTC
[GitHub] [cassandra] Gerrrr opened a new pull request #506: CASSANDRA-15679
Don't use bytearray for blobs in copyutil.py
Gerrrr opened a new pull request #506: CASSANDRA-15679 Don't use bytearray for blobs in copyutil.py
URL: https://github.com/apache/cassandra/pull/506
* Use str in Python 2
* Use bytes in Python 3
https://issues.apache.org/jira/browse/CASSANDRA-15679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] stef1927 commented on a change in pull request #506:
CASSANDRA-15679 Don't use bytearray for blobs in copyutil.py 4.0
Posted by GitBox <gi...@apache.org>.
stef1927 commented on a change in pull request #506: CASSANDRA-15679 Don't use bytearray for blobs in copyutil.py 4.0
URL: https://github.com/apache/cassandra/pull/506#discussion_r402537088
##########
File path: pylib/cqlshlib/copyutil.py
##########
@@ -1933,7 +1933,10 @@ def convert_mandatory(t, v):
return converters.get(t.typename, convert_unknown)(v, ct=t)
def convert_blob(v, **_):
- return bytearray.fromhex(v[2:])
+ if sys.version_info.major >= 3:
+ return bytes.fromhex(v[:2])
Review comment:
`2:`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] Gerrrr closed pull request #506: CASSANDRA-15679 Don't
use bytearray for blobs in copyutil.py 4.0
Posted by GitBox <gi...@apache.org>.
Gerrrr closed pull request #506: CASSANDRA-15679 Don't use bytearray for blobs in copyutil.py 4.0
URL: https://github.com/apache/cassandra/pull/506
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org