You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "marcingrzejszczak (via GitHub)" <gi...@apache.org> on 2023/08/24 10:25:04 UTC
[GitHub] [rocketmq] marcingrzejszczak opened a new pull request, #7248: Micrometer observation
marcingrzejszczak opened a new pull request, #7248:
URL: https://github.com/apache/rocketmq/pull/7248
This is a draft PR since there are a couple of questions / issues that need to be addressed
- I've created a separate `micrometer` package so that the code is isolated, but I can move it next to OpenTracing packages
- I tried to follow the current (24.08.2023) Semantic conventions for messaging https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/messaging/ but need help with all the remaining `TODO:` comments as far as tags are concerned
- Where should we put the documentation to this integration?
- How do we deal with scoping (span scopes) when consuming batches? How often do we process a single message? If we left an open scope for a span how would users then close it? Can it be done automatically?
### Which Issue(s) This PR Fixes
https://github.com/apache/rocketmq/issues/7055
### Brief Description
Adds Micrometer Observation support via the `ConsumeMessageHook` and `SendMessageHook`
### How Did You Test This Change?
I've added 2 tests that reuse OpenTracing's testing approach. They test for the presence of spans and metrics.
Got the following results in Zipkin:
.Receive Span
.Produce Span
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Micrometer observation [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7248:
URL: https://github.com/apache/rocketmq/pull/7248#issuecomment-2350727394
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Micrometer observation [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7248:
URL: https://github.com/apache/rocketmq/pull/7248#issuecomment-3290074696
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Micrometer observation [rocketmq]
Posted by "jonatan-ivanov (via GitHub)" <gi...@apache.org>.
jonatan-ivanov commented on PR #7248:
URL: https://github.com/apache/rocketmq/pull/7248#issuecomment-5690417219
Could somebody please add no stale label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] marcingrzejszczak commented on pull request #7248: Micrometer observation
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #7248:
URL: https://github.com/apache/rocketmq/pull/7248#issuecomment-1719097619
hey @vintagewang @YangJodie , WDYT about this feature? Are you willing to accept it in any way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Micrometer observation [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7248:
URL: https://github.com/apache/rocketmq/pull/7248#issuecomment-5690003235
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Micrometer observation [rocketmq]
Posted by "jonatan-ivanov (via GitHub)" <gi...@apache.org>.
jonatan-ivanov commented on PR #7248:
URL: https://github.com/apache/rocketmq/pull/7248#issuecomment-2350842173
@vintagewang @YangJodie Could you please add no stale label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Micrometer observation [rocketmq]
Posted by "jonatan-ivanov (via GitHub)" <gi...@apache.org>.
jonatan-ivanov commented on PR #7248:
URL: https://github.com/apache/rocketmq/pull/7248#issuecomment-3290521103
Could somebody please add no stale label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org