You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Sandrine Raffalli (JIRA)" <ji...@apache.org> on 2009/01/22 11:43:59 UTC

[jira] Created: (JCR-1949) NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)

NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)
--------------------------------------------------------------------------------------------------------------------------

                 Key: JCR-1949
                 URL: https://issues.apache.org/jira/browse/JCR-1949
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: indexing
    Affects Versions: 1.6.0
            Reporter: Sandrine Raffalli
            Priority: Blocker


There is a NullPointerException when jackrabbit try to synchronise its indexes :
22 janv. 2009 09:53:56 INFO  [ClusterNode] - Processing revision: 4485
22 janv. 2009 09:53:56 ERROR [ClusterNode] - Unexpected error while syncing of journal: null
java.lang.NullPointerException
        at org.apache.jackrabbit.core.observation.DelegatingObservationDispatcher.createEventStateCollection(DelegatingObservationDispatcher.java:80)
        at org.apache.jackrabbit.core.version.VersionManagerImpl$DynamicESCFactory.createEventStateCollection(VersionManagerImpl.java:556)
        at org.apache.jackrabbit.core.version.VersionManagerImpl.externalUpdate(VersionManagerImpl.java:500)
        at org.apache.jackrabbit.core.cluster.ClusterNode.process(ClusterNode.java:853)
        at org.apache.jackrabbit.core.cluster.ChangeLogRecord.process(ChangeLogRecord.java:457)
        at org.apache.jackrabbit.core.cluster.ClusterNode.consume(ClusterNode.java:799)
        at org.apache.jackrabbit.core.journal.AbstractJournal.doSync(AbstractJournal.java:213)
        at org.apache.jackrabbit.core.journal.AbstractJournal.sync(AbstractJournal.java:188)
        at org.apache.jackrabbit.core.cluster.ClusterNode.sync(ClusterNode.java:315)
        at org.apache.jackrabbit.core.cluster.ClusterNode.run(ClusterNode.java:286)
        at java.lang.Thread.run(Thread.java:595)

In fact the method createEventStateCollection() of DelegatingObservationDispatcher is called by the VersionManagerImpl with session parameter as null...

DelegatingObservationDispatcher:

 public EventStateCollection createEventStateCollection(SessionImpl session,
                                                           Path pathPrefix) {
        String userData = null;
        try {
            userData = ((ObservationManagerImpl) session.getWorkspace().getObservationManager()).getUserData();
        } catch (RepositoryException e) {
            // should never happen because this
            // implementation supports observation
        }
        return new EventStateCollection(this, session, pathPrefix, userData);
    }

VersionManagerImpl$DynamicESCFactory :
 public EventStateCollection createEventStateCollection(SessionImpl source) {
            return obsMgr.createEventStateCollection(source, VERSION_STORAGE_PATH);
        }

VersionManagerImpl :
public void externalUpdate(ChangeLog changes, List events,
                               long timestamp, String userData)
            throws RepositoryException {
        EventStateCollection esc = getEscFactory().createEventStateCollection(null);
        esc.addAll(events);
        esc.setTimestamp(timestamp);
        esc.setUserData(userData);

        sharedStateMgr.externalUpdate(changes, esc);
    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1949) NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)

Posted by "Sandrine Raffalli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandrine Raffalli updated JCR-1949:
-----------------------------------

    Component/s: versioning
                 jackrabbit-core

> NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1949
>                 URL: https://issues.apache.org/jira/browse/JCR-1949
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core, versioning
>    Affects Versions: 1.6.0
>            Reporter: Sandrine Raffalli
>            Priority: Blocker
>
> There is a NullPointerException when jackrabbit try to synchronise its indexes :
> 22 janv. 2009 09:53:56 INFO  [ClusterNode] - Processing revision: 4485
> 22 janv. 2009 09:53:56 ERROR [ClusterNode] - Unexpected error while syncing of journal: null
> java.lang.NullPointerException
>         at org.apache.jackrabbit.core.observation.DelegatingObservationDispatcher.createEventStateCollection(DelegatingObservationDispatcher.java:80)
>         at org.apache.jackrabbit.core.version.VersionManagerImpl$DynamicESCFactory.createEventStateCollection(VersionManagerImpl.java:556)
>         at org.apache.jackrabbit.core.version.VersionManagerImpl.externalUpdate(VersionManagerImpl.java:500)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.process(ClusterNode.java:853)
>         at org.apache.jackrabbit.core.cluster.ChangeLogRecord.process(ChangeLogRecord.java:457)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.consume(ClusterNode.java:799)
>         at org.apache.jackrabbit.core.journal.AbstractJournal.doSync(AbstractJournal.java:213)
>         at org.apache.jackrabbit.core.journal.AbstractJournal.sync(AbstractJournal.java:188)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.sync(ClusterNode.java:315)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.run(ClusterNode.java:286)
>         at java.lang.Thread.run(Thread.java:595)
> In fact the method createEventStateCollection() of DelegatingObservationDispatcher is called by the VersionManagerImpl with session parameter as null...
> DelegatingObservationDispatcher:
>  public EventStateCollection createEventStateCollection(SessionImpl session,
>                                                            Path pathPrefix) {
>         String userData = null;
>         try {
>             userData = ((ObservationManagerImpl) session.getWorkspace().getObservationManager()).getUserData();
>         } catch (RepositoryException e) {
>             // should never happen because this
>             // implementation supports observation
>         }
>         return new EventStateCollection(this, session, pathPrefix, userData);
>     }
> VersionManagerImpl$DynamicESCFactory :
>  public EventStateCollection createEventStateCollection(SessionImpl source) {
>             return obsMgr.createEventStateCollection(source, VERSION_STORAGE_PATH);
>         }
> VersionManagerImpl :
> public void externalUpdate(ChangeLog changes, List events,
>                                long timestamp, String userData)
>             throws RepositoryException {
>         EventStateCollection esc = getEscFactory().createEventStateCollection(null);
>         esc.addAll(events);
>         esc.setTimestamp(timestamp);
>         esc.setUserData(userData);
>         sharedStateMgr.externalUpdate(changes, esc);
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1949) NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger updated JCR-1949:
----------------------------------

    Attachment: JCR-1949.patch

The patch seems incomplete. Here's my try at it.

> NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1949
>                 URL: https://issues.apache.org/jira/browse/JCR-1949
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core, versioning
>    Affects Versions: 1.6.0
>            Reporter: Sandrine Raffalli
>            Priority: Blocker
>         Attachments: JCR-1949.patch, JCR-1949.patch
>
>
> There is a NullPointerException when jackrabbit try to synchronise its indexes :
> 22 janv. 2009 09:53:56 INFO  [ClusterNode] - Processing revision: 4485
> 22 janv. 2009 09:53:56 ERROR [ClusterNode] - Unexpected error while syncing of journal: null
> java.lang.NullPointerException
>         at org.apache.jackrabbit.core.observation.DelegatingObservationDispatcher.createEventStateCollection(DelegatingObservationDispatcher.java:80)
>         at org.apache.jackrabbit.core.version.VersionManagerImpl$DynamicESCFactory.createEventStateCollection(VersionManagerImpl.java:556)
>         at org.apache.jackrabbit.core.version.VersionManagerImpl.externalUpdate(VersionManagerImpl.java:500)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.process(ClusterNode.java:853)
>         at org.apache.jackrabbit.core.cluster.ChangeLogRecord.process(ChangeLogRecord.java:457)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.consume(ClusterNode.java:799)
>         at org.apache.jackrabbit.core.journal.AbstractJournal.doSync(AbstractJournal.java:213)
>         at org.apache.jackrabbit.core.journal.AbstractJournal.sync(AbstractJournal.java:188)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.sync(ClusterNode.java:315)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.run(ClusterNode.java:286)
>         at java.lang.Thread.run(Thread.java:595)
> In fact the method createEventStateCollection() of DelegatingObservationDispatcher is called by the VersionManagerImpl with session parameter as null...
> DelegatingObservationDispatcher:
>  public EventStateCollection createEventStateCollection(SessionImpl session,
>                                                            Path pathPrefix) {
>         String userData = null;
>         try {
>             userData = ((ObservationManagerImpl) session.getWorkspace().getObservationManager()).getUserData();
>         } catch (RepositoryException e) {
>             // should never happen because this
>             // implementation supports observation
>         }
>         return new EventStateCollection(this, session, pathPrefix, userData);
>     }
> VersionManagerImpl$DynamicESCFactory :
>  public EventStateCollection createEventStateCollection(SessionImpl source) {
>             return obsMgr.createEventStateCollection(source, VERSION_STORAGE_PATH);
>         }
> VersionManagerImpl :
> public void externalUpdate(ChangeLog changes, List events,
>                                long timestamp, String userData)
>             throws RepositoryException {
>         EventStateCollection esc = getEscFactory().createEventStateCollection(null);
>         esc.addAll(events);
>         esc.setTimestamp(timestamp);
>         esc.setUserData(userData);
>         sharedStateMgr.externalUpdate(changes, esc);
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-1949) NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger resolved JCR-1949.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6.0

Committed my version of the patch in revision: 745824

> NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1949
>                 URL: https://issues.apache.org/jira/browse/JCR-1949
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core, versioning
>    Affects Versions: 1.6.0
>            Reporter: Sandrine Raffalli
>            Priority: Blocker
>             Fix For: 1.6.0
>
>         Attachments: JCR-1949.patch, JCR-1949.patch
>
>
> There is a NullPointerException when jackrabbit try to synchronise its indexes :
> 22 janv. 2009 09:53:56 INFO  [ClusterNode] - Processing revision: 4485
> 22 janv. 2009 09:53:56 ERROR [ClusterNode] - Unexpected error while syncing of journal: null
> java.lang.NullPointerException
>         at org.apache.jackrabbit.core.observation.DelegatingObservationDispatcher.createEventStateCollection(DelegatingObservationDispatcher.java:80)
>         at org.apache.jackrabbit.core.version.VersionManagerImpl$DynamicESCFactory.createEventStateCollection(VersionManagerImpl.java:556)
>         at org.apache.jackrabbit.core.version.VersionManagerImpl.externalUpdate(VersionManagerImpl.java:500)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.process(ClusterNode.java:853)
>         at org.apache.jackrabbit.core.cluster.ChangeLogRecord.process(ChangeLogRecord.java:457)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.consume(ClusterNode.java:799)
>         at org.apache.jackrabbit.core.journal.AbstractJournal.doSync(AbstractJournal.java:213)
>         at org.apache.jackrabbit.core.journal.AbstractJournal.sync(AbstractJournal.java:188)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.sync(ClusterNode.java:315)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.run(ClusterNode.java:286)
>         at java.lang.Thread.run(Thread.java:595)
> In fact the method createEventStateCollection() of DelegatingObservationDispatcher is called by the VersionManagerImpl with session parameter as null...
> DelegatingObservationDispatcher:
>  public EventStateCollection createEventStateCollection(SessionImpl session,
>                                                            Path pathPrefix) {
>         String userData = null;
>         try {
>             userData = ((ObservationManagerImpl) session.getWorkspace().getObservationManager()).getUserData();
>         } catch (RepositoryException e) {
>             // should never happen because this
>             // implementation supports observation
>         }
>         return new EventStateCollection(this, session, pathPrefix, userData);
>     }
> VersionManagerImpl$DynamicESCFactory :
>  public EventStateCollection createEventStateCollection(SessionImpl source) {
>             return obsMgr.createEventStateCollection(source, VERSION_STORAGE_PATH);
>         }
> VersionManagerImpl :
> public void externalUpdate(ChangeLog changes, List events,
>                                long timestamp, String userData)
>             throws RepositoryException {
>         EventStateCollection esc = getEscFactory().createEventStateCollection(null);
>         esc.addAll(events);
>         esc.setTimestamp(timestamp);
>         esc.setUserData(userData);
>         sharedStateMgr.externalUpdate(changes, esc);
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1949) NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1949:
-------------------------------

    Attachment: JCR-1949.patch

The attached patch should fix the issue, but I'm not too familiar with the JCR-1904 details to know if this is the best way to do this.

> NullPointerException on DelegatingObservationDispatcher cause by parameter null on call : createEventStateCollection(null)
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1949
>                 URL: https://issues.apache.org/jira/browse/JCR-1949
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core, versioning
>    Affects Versions: 1.6.0
>            Reporter: Sandrine Raffalli
>            Priority: Blocker
>         Attachments: JCR-1949.patch
>
>
> There is a NullPointerException when jackrabbit try to synchronise its indexes :
> 22 janv. 2009 09:53:56 INFO  [ClusterNode] - Processing revision: 4485
> 22 janv. 2009 09:53:56 ERROR [ClusterNode] - Unexpected error while syncing of journal: null
> java.lang.NullPointerException
>         at org.apache.jackrabbit.core.observation.DelegatingObservationDispatcher.createEventStateCollection(DelegatingObservationDispatcher.java:80)
>         at org.apache.jackrabbit.core.version.VersionManagerImpl$DynamicESCFactory.createEventStateCollection(VersionManagerImpl.java:556)
>         at org.apache.jackrabbit.core.version.VersionManagerImpl.externalUpdate(VersionManagerImpl.java:500)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.process(ClusterNode.java:853)
>         at org.apache.jackrabbit.core.cluster.ChangeLogRecord.process(ChangeLogRecord.java:457)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.consume(ClusterNode.java:799)
>         at org.apache.jackrabbit.core.journal.AbstractJournal.doSync(AbstractJournal.java:213)
>         at org.apache.jackrabbit.core.journal.AbstractJournal.sync(AbstractJournal.java:188)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.sync(ClusterNode.java:315)
>         at org.apache.jackrabbit.core.cluster.ClusterNode.run(ClusterNode.java:286)
>         at java.lang.Thread.run(Thread.java:595)
> In fact the method createEventStateCollection() of DelegatingObservationDispatcher is called by the VersionManagerImpl with session parameter as null...
> DelegatingObservationDispatcher:
>  public EventStateCollection createEventStateCollection(SessionImpl session,
>                                                            Path pathPrefix) {
>         String userData = null;
>         try {
>             userData = ((ObservationManagerImpl) session.getWorkspace().getObservationManager()).getUserData();
>         } catch (RepositoryException e) {
>             // should never happen because this
>             // implementation supports observation
>         }
>         return new EventStateCollection(this, session, pathPrefix, userData);
>     }
> VersionManagerImpl$DynamicESCFactory :
>  public EventStateCollection createEventStateCollection(SessionImpl source) {
>             return obsMgr.createEventStateCollection(source, VERSION_STORAGE_PATH);
>         }
> VersionManagerImpl :
> public void externalUpdate(ChangeLog changes, List events,
>                                long timestamp, String userData)
>             throws RepositoryException {
>         EventStateCollection esc = getEscFactory().createEventStateCollection(null);
>         esc.addAll(events);
>         esc.setTimestamp(timestamp);
>         esc.setUserData(userData);
>         sharedStateMgr.externalUpdate(changes, esc);
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.