[jira] [Comment Edited] (HBASE-22009) Improve RSGroupInfoManagerImpl#getDefaultServers()

["Xiang Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792406#comment-16792406 ] 

Xiang Li edited comment on HBASE-22009 at 3/14/19 7:37 AM:
-----------------------------------------------------------

[~xucang][~yuzhihong@gmail.com][~stack]Could you please to review the patch when you are available? By the way, is there anyone in the community focusing on rsgoup? Or the guy I could go to for the JIRA/issue on rsgroup.


was (Author: water):
[~stack] Could you please to review the patch when you are available? By the way, is there anyone in the community focusing on rsgoup? Or the guy I could go to for the JIRA/issue on rsgroup.

> Improve RSGroupInfoManagerImpl#getDefaultServers()
> --------------------------------------------------
>
>                 Key: HBASE-22009
>                 URL: https://issues.apache.org/jira/browse/HBASE-22009
>             Project: HBase
>          Issue Type: Improvement
>          Components: rsgroup
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>         Attachments: HBASE-22009.master.000.patch
>
>
> {code:title=RSGroupInfoManagerImpl.java|borderStyle=solid}
> private SortedSet<Address> getDefaultServers() throws IOException {
>   SortedSet<Address> defaultServers = Sets.newTreeSet();
>   for (ServerName serverName : getOnlineRS()) {
>     Address server = Address.fromParts(serverName.getHostname(), serverName.getPort());
>     boolean found = false;
>     for (RSGroupInfo rsgi : listRSGroups()) {
>       if (!RSGroupInfo.DEFAULT_GROUP.equals(rsgi.getName()) && rsgi.containsServer(server)) {
>         found = true;
>         break;
>       }
>     }
>     if (!found) {
>       defaultServers.add(server);
>     }
>   }
>   return defaultServers;
> }
> {code}
> That is a logic of 2 nest loops. And for each server, listRSGroups() allocates a new LinkedList and calls Map#values(), both of which are very heavy operations.
> Maybe the inner loop could be moved out, that is
> # Build a list of servers of other groups than default group
> # Iterate each online servers and check if it is in the list above. If it is not, then it belongs to default group.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)