You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/11/17 14:23:16 UTC
[PR] WIP bump rtools/R version in CI [arrow]
paleolimbot opened a new pull request, #38761:
URL: https://github.com/apache/arrow/pull/38761
### Rationale for this change
The versions of Rtools and R in the CI config are no longer current
### What changes are included in this PR?
The versions are bumped: r-release is now 4.3 and both r-release and r-devel use Rtools43.
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38762: [R] Bump rtools/R version in CI [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed pull request #38761: GH-38762: [R] Bump rtools/R version in CI
URL: https://github.com/apache/arrow/pull/38761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38762: [R] Bump rtools/R version in CI [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #38761:
URL: https://github.com/apache/arrow/pull/38761#discussion_r1398050839
##########
dev/tasks/macros.jinja:
##########
@@ -362,8 +362,8 @@ on:
{# use filter to cast to string and convert to lowercase to match yaml boolean #}
{% set is_fork = (not is_upstream_b)|lower %}
-{% set r_release = {"ver": "4.2", "rt" : "42"} %}
-{% set r_oldrel = {"ver": "4.1", "rt" : "40"} %}
+{% set r_release = {"ver": "4.3", "rt" : "43"} %}
+{% set r_oldrel = {"ver": "4.2", "rt" : "42"} %}
Review Comment:
We can't update the 10.13 runner because there is no easy way to switch versions (versions of `rig` that contain 4.3 don't work on 10.13 anymore, even when build from source). We could of course special case that to run on 4.2/1 and update the other builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP bump rtools/R version in CI [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38761:
URL: https://github.com/apache/arrow/pull/38761#issuecomment-1816522895
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38762: [R] Bump rtools/R version in CI [arrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #38761:
URL: https://github.com/apache/arrow/pull/38761#issuecomment-1832511697
Closing as #38927 did most of the changes here (and other the other changes are better done when the MacOS runners are sorted)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38762: [R] Bump rtools/R version in CI [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38761:
URL: https://github.com/apache/arrow/pull/38761#issuecomment-1816531663
:warning: GitHub issue #38762 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org