You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/30 07:54:29 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #38849: [SPARK-41328][CONNECT][PYTHON][FOLLOW-UP] Simplify startsWith and endsWith

amaliujia commented on code in PR #38849:
URL: https://github.com/apache/spark/pull/38849#discussion_r1035633581


##########
python/pyspark/sql/connect/column.py:
##########
@@ -508,45 +508,24 @@ def contains(self, other: Union[PrimitiveType, "Column"]) -> "Column":
         """
         return _bin_op("contains")(self, other)
 
-    def startswith(self, other: Union[PrimitiveType, "Column"]) -> "Column":
-        """
-        String starts with. Returns a boolean :class:`Column` based on a string match.
-
-        Parameters
-        ----------
-        other : :class:`Column` or str
-            string at start of line (do not use a regex `^`)
-
-        Examples
-        --------
-        >>> df = spark.createDataFrame(
-        ...      [(2, "Alice"), (5, "Bob")], ["age", "name"])

Review Comment:
   This does not work in current Connect `createDataFrame` which does not allow a `schema`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org