You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ahmedgabers (via GitHub)" <gi...@apache.org> on 2026/08/26 15:20:33 UTC

[PR] feat(apisix): render extraContainers through tpl [apisix-helm-chart]

ahmedgabers opened a new pull request, #1003:
URL: https://github.com/apache/apisix-helm-chart/pull/1003

   extraContainers entries are raw container specs, so an image reference inside them cannot be composed from other values the way first-class image fields can. Rendering the list through `tpl` lets entries carry template expressions (e.g. `image: "{{ .Values.someRepository }}:{{ .Values.someTag }}"`), matching the common pattern for extra-container passthroughs. Plain specs render unchanged.
   
   Verified with `helm template`: a templated entry expands correctly, and untemplated values render byte-identical to the current output. Chart version bumped 2.17.0 -> 2.17.1; values doc comment and README row updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(apisix): render extraContainers through tpl [apisix-helm-chart]

Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan closed pull request #1003: feat(apisix): render extraContainers through tpl
URL: https://github.com/apache/apisix-helm-chart/pull/1003


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(apisix): render extraContainers through tpl [apisix-helm-chart]

Posted by "ahmedgabers (via GitHub)" <gi...@apache.org>.
ahmedgabers commented on PR #1003:
URL: https://github.com/apache/apisix-helm-chart/pull/1003#issuecomment-5427590545

   Fixes #1005.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(apisix): render extraContainers through tpl [apisix-helm-chart]

Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan closed pull request #1003: feat(apisix): render extraContainers through tpl
URL: https://github.com/apache/apisix-helm-chart/pull/1003


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org