You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2023/07/13 07:27:42 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #32578: Add setup/teardown info to grid/graph view
bbovenzi opened a new pull request, #32578:
URL: https://github.com/apache/airflow/pull/32578
Continuation of https://github.com/apache/airflow/pull/32268.
Use the updated graph_data to show which nodes are setup or teardown tasks.
Update grid_data to include the same info to include it in the task details and tooltip.
Add `is_setup_teardown` to `dag_edges()` so that we can render a dashed line for edges directly in between setup/teardown tasks.
<img width="1184" alt="Screenshot 2023-07-13 at 3 27 29 PM" src="https://github.com/apache/airflow/assets/4600967/4e9b0c61-dda3-4fd7-832f-5888f7534491">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #32578: Add setup/teardown info to grid/graph view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #32578:
URL: https://github.com/apache/airflow/pull/32578#issuecomment-1635047887
Oops. I was too eager to merge. If anyone has any comments, I'm happy to fix them in a follow-up before we release 2.7.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #32578: Add setup/teardown info to grid/graph view
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #32578:
URL: https://github.com/apache/airflow/pull/32578#issuecomment-1634520561
I've refactored the edge marking code a bit (this also fixed the tests), please take another look reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #32578: Add setup/teardown info to grid/graph view
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #32578:
URL: https://github.com/apache/airflow/pull/32578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org