You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "liuminghui233 (via GitHub)" <gi...@apache.org> on 2024/02/22 09:18:04 UTC
[PR] Fix bug in [iotdb]
liuminghui233 opened a new pull request, #12068:
URL: https://github.com/apache/iotdb/pull/12068
**[Reproduction Method]**
- **Config:**
maxNumberOfPointsInPage = 2
maxTsBlockLineNumber = 3
- **Insert:**
```SQL
CREATE DATABASE root.sg1;
create aligned timeseries root.sg1.d1(s1 FLOAT encoding=RLE, s2 INT32 encoding=Gorilla compression=SNAPPY, s3 INT64, s4 BOOLEAN, s5 TEXT);
insert into root.sg1.d1(time, s1, s2, s3, s4, s5) aligned values(1, 1.0, 1, 1, TRUE, 'aligned_test1');
insert into root.sg1.d1(time, s1, s2, s3, s5) aligned values(2, 2.0, 2, 2, 'aligned_test2');
insert into root.sg1.d1(time, s1, s3, s4, s5) aligned values(3, 3.0, 3, FALSE, 'aligned_test3');
insert into root.sg1.d1(time, s1, s2, s4, s5) aligned values(4, 4.0, 4, TRUE, 'aligned_test4');
insert into root.sg1.d1(time, s1, s2, s4, s5) aligned values(5, 5.0, 5, TRUE, 'aligned_test5');
insert into root.sg1.d1(time, s1, s2, s3, s4) aligned values(6, 6.0, 6, 6, TRUE);
insert into root.sg1.d1(time, s1, s2, s3, s4, s5) aligned values(7, 7.0, 7, 7, FALSE, 'aligned_test7');
insert into root.sg1.d1(time, s1, s2, s3, s5) aligned values(8, 8.0, 8, 8, 'aligned_test8');
insert into root.sg1.d1(time, s1, s2, s3, s4, s5) aligned values(9, 9.0, 9, 9, FALSE, 'aligned_test9');
insert into root.sg1.d1(time, s2, s3, s4, s5) aligned values(10, 10, 10, TRUE, 'aligned_test10');
flush;
insert into root.sg1.d1(time, s1, s3, s4, s5) aligned values(3, 30000.0, 30000, TRUE, 'aligned_unseq_test3');
insert into root.sg1.d1(time, s1, s2, s3) aligned values(11, 11.0, 11, 11);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(12, 12.0, 12, 12);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(13, 13.0, 13, 13);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(14, 14.0, 14, 14);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(15, 15.0, 15, 15);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(16, 16.0, 16, 16);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(17, 17.0, 17, 17);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(18, 18.0, 18, 18);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(19, 19.0, 19, 19);
insert into root.sg1.d1(time, s1, s2, s3) aligned values(20, 20.0, 20, 20);
flush;
insert into root.sg1.d1(time, s1, s2, s3, s4, s5) aligned values(13, 130000.0, 130000, 130000, TRUE, 'aligned_unseq_test13');
flush;
```
- **Query:**
```SQL
select * from root.sg1.d1 where time >= 9 and time <= 33 offset 5 limit 5
```
- Before:

- After:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bug in merging overlapped data process caused by filter & offset push down [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12068:
URL: https://github.com/apache/iotdb/pull/12068#issuecomment-1959046113
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12068) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12068&metric=new_coverage&view=list) (required ≥ 80%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12068)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6299] Fix bug in merging overlapped data process caused by filter & offset push down [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12068:
URL: https://github.com/apache/iotdb/pull/12068#issuecomment-1959665316
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12068) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12068&metric=new_coverage&view=list) (required ≥ 80%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12068)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6299] Fix bug in merging overlapped data process caused by filter & offset push down [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #12068:
URL: https://github.com/apache/iotdb/pull/12068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org