You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/08/29 09:12:38 UTC
Review Request: Refactored flags loaders to take a "parse" function for
better code reuse and organization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6824/
-----------------------------------------------------------
Review request for mesos and John Sirois.
Description
-------
See summary.
Diffs
-----
src/Makefile.am aaceee3
src/flags/flags.hpp aca3be5
src/flags/loader.hpp d7be7b9
src/flags/parse.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/6824/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Refactored flags loaders to take a "parse" function for
better code reuse and organization.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6824/#review10876
-----------------------------------------------------------
Ship it!
Thanks! This lgtm.
The other bit that would be nice to get rid of is abort() in the loads so you can test the failure path and lift abort toa more main-like context where abort decisions seem more appropriate
- John Sirois
On Aug. 30, 2012, 4:16 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6824/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 4:16 a.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am aaceee3
> src/flags/flags.hpp aca3be5
> src/flags/loader.hpp d7be7b9
> src/flags/parse.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6824/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Refactored flags loaders to take a "parse" function for
better code reuse and organization.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 30, 2012, 4:51 a.m., Vinod Kone wrote:
> > src/flags/flags.hpp, line 99
> > <https://reviews.apache.org/r/6824/diff/1/?file=147065#file147065line99>
> >
> > Flags as a typename is awkward to read. Why not F to be consistent?
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6824/#review10877
-----------------------------------------------------------
On Aug. 30, 2012, 4:16 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6824/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 4:16 a.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am aaceee3
> src/flags/flags.hpp aca3be5
> src/flags/loader.hpp d7be7b9
> src/flags/parse.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6824/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Refactored flags loaders to take a "parse" function for
better code reuse and organization.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6824/#review10877
-----------------------------------------------------------
Ship it!
src/flags/flags.hpp
<https://reviews.apache.org/r/6824/#comment23436>
Flags as a typename is awkward to read. Why not F to be consistent?
- Vinod Kone
On Aug. 30, 2012, 4:16 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6824/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 4:16 a.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am aaceee3
> src/flags/flags.hpp aca3be5
> src/flags/loader.hpp d7be7b9
> src/flags/parse.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6824/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Refactored flags loaders to take a "parse" function for
better code reuse and organization.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6824/
-----------------------------------------------------------
(Updated Aug. 30, 2012, 4:16 a.m.)
Review request for mesos, John Sirois and Vinod Kone.
Changes
-------
Ping (plus added vinodkone).
Description
-------
See summary.
Diffs
-----
src/Makefile.am aaceee3
src/flags/flags.hpp aca3be5
src/flags/loader.hpp d7be7b9
src/flags/parse.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/6824/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman