[GitHub] sunithabeeram commented on a change in pull request #3336: Add metadata info and metric when querying non-existing columns

[GitBox <gi...@apache.org>]

sunithabeeram commented on a change in pull request #3336: Add metadata info and metric when querying non-existing columns
URL: https://github.com/apache/incubator-pinot/pull/3336#discussion_r236923422
 
 

 ##########
 File path: pinot-core/src/main/java/com/linkedin/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
 ##########
 @@ -143,6 +147,22 @@ public DataTable processQuery(ServerQueryRequest queryRequest, ExecutorService e
         metadata.put(DataTable.NUM_ENTRIES_SCANNED_POST_FILTER_METADATA_KEY, "0");
         metadata.put(DataTable.NUM_SEGMENTS_PROCESSED, "0");
         metadata.put(DataTable.NUM_SEGMENTS_MATCHED, "0");
+
+        // adds pruning reasons to metadata.
+        StringBuilder pruningReasons = new StringBuilder();
+        for (SegmentPruner segmentPruner : matchedSegmentPruners) {
+          // emits metric when querying non-existing columns.
+          if ("DataSchemaSegmentPruner".equals(segmentPruner.toString())) {
 
 Review comment:
   This seems a bit involved to surface the information we are looking for. Can this be handled better on the broker side? Broker can cache the schema and check for columns queried against the schema?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org