You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/20 19:40:15 UTC
[GitHub] [beam] ibzib commented on a change in pull request #13689: [BEAM-10961] Enabled strict dependency on SDKS-Testing
ibzib commented on a change in pull request #13689:
URL: https://github.com/apache/beam/pull/13689#discussion_r561224397
##########
File path: sdks/java/testing/test-utils/build.gradle
##########
@@ -30,12 +31,15 @@ dependencies {
compile project(path: ":sdks:java:core", configuration: "shadow")
compile library.java.vendored_guava_26_0_jre
compile library.java.google_cloud_bigquery
- compile project(":sdks:java:extensions:google-cloud-platform-core")
+ compile "com.google.code.gson:gson:2.8.6"
+ compile library.java.joda_time
+ compile "org.apache.commons:commons-compress:1.20"
Review comment:
```suggestion
compile library.java.commons_compress
```
##########
File path: sdks/java/testing/test-utils/build.gradle
##########
@@ -30,12 +31,15 @@ dependencies {
compile project(path: ":sdks:java:core", configuration: "shadow")
compile library.java.vendored_guava_26_0_jre
compile library.java.google_cloud_bigquery
- compile project(":sdks:java:extensions:google-cloud-platform-core")
+ compile "com.google.code.gson:gson:2.8.6"
+ compile library.java.joda_time
+ compile "org.apache.commons:commons-compress:1.20"
+ compile "org.apache.commons:commons-lang3:3.9"
Review comment:
```suggestion
compile library.java.commons_lang3
```
##########
File path: sdks/java/testing/load-tests/build.gradle
##########
@@ -61,14 +62,18 @@ configurations {
dependencies {
compile library.java.kafka_clients
-
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":runners:direct-java", configuration: "shadow")
compile project(":sdks:java:io:synthetic")
compile project(":sdks:java:testing:test-utils")
compile project(":sdks:java:io:google-cloud-platform")
compile project(":sdks:java:io:kafka")
compile project(":sdks:java:io:kinesis")
+ compile "com.amazonaws:aws-java-sdk-core:1.11.718"
+ compile "com.google.cloud:google-cloud-core:1.93.7"
Review comment:
```suggestion
compile library.java.google_cloud_core
```
##########
File path: sdks/java/testing/load-tests/build.gradle
##########
@@ -61,14 +62,18 @@ configurations {
dependencies {
compile library.java.kafka_clients
-
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":runners:direct-java", configuration: "shadow")
compile project(":sdks:java:io:synthetic")
compile project(":sdks:java:testing:test-utils")
compile project(":sdks:java:io:google-cloud-platform")
compile project(":sdks:java:io:kafka")
compile project(":sdks:java:io:kinesis")
+ compile "com.amazonaws:aws-java-sdk-core:1.11.718"
+ compile "com.google.cloud:google-cloud-core:1.93.7"
+ compile library.java.joda_time
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
```suggestion
```
##########
File path: sdks/java/testing/load-tests/build.gradle
##########
@@ -61,14 +62,18 @@ configurations {
dependencies {
compile library.java.kafka_clients
-
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":runners:direct-java", configuration: "shadow")
compile project(":sdks:java:io:synthetic")
compile project(":sdks:java:testing:test-utils")
compile project(":sdks:java:io:google-cloud-platform")
compile project(":sdks:java:io:kafka")
compile project(":sdks:java:io:kinesis")
+ compile "com.amazonaws:aws-java-sdk-core:1.11.718"
Review comment:
```suggestion
compile library.java.aws_java_sdk_core
```
##########
File path: sdks/java/testing/nexmark/build.gradle
##########
@@ -62,6 +63,10 @@ dependencies {
compile project(":sdks:java:extensions:sql:zetasql")
compile project(":sdks:java:io:kafka")
compile project(":sdks:java:testing:test-utils")
+ compile "com.google.api-client:google-api-client:1.30.10"
+ compile "junit:junit:4.13-beta-3"
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
```suggestion
```
##########
File path: sdks/java/testing/test-utils/build.gradle
##########
@@ -30,12 +31,15 @@ dependencies {
compile project(path: ":sdks:java:core", configuration: "shadow")
compile library.java.vendored_guava_26_0_jre
compile library.java.google_cloud_bigquery
- compile project(":sdks:java:extensions:google-cloud-platform-core")
+ compile "com.google.code.gson:gson:2.8.6"
Review comment:
```suggestion
compile library.java.google_code_gson
```
##########
File path: sdks/java/testing/test-utils/build.gradle
##########
@@ -30,12 +31,15 @@ dependencies {
compile project(path: ":sdks:java:core", configuration: "shadow")
compile library.java.vendored_guava_26_0_jre
compile library.java.google_cloud_bigquery
- compile project(":sdks:java:extensions:google-cloud-platform-core")
+ compile "com.google.code.gson:gson:2.8.6"
+ compile library.java.joda_time
+ compile "org.apache.commons:commons-compress:1.20"
+ compile "org.apache.commons:commons-lang3:3.9"
+ compile "org.apache.httpcomponents:httpclient:4.5.10"
Review comment:
These don't currently have a common definition in BeamModulePlugin, but they should. BEAM-11669
##########
File path: sdks/java/testing/nexmark/build.gradle
##########
@@ -62,6 +63,10 @@ dependencies {
compile project(":sdks:java:extensions:sql:zetasql")
compile project(":sdks:java:io:kafka")
compile project(":sdks:java:testing:test-utils")
+ compile "com.google.api-client:google-api-client:1.30.10"
Review comment:
```suggestion
compile library.java.google_api_client
```
##########
File path: sdks/java/testing/nexmark/build.gradle
##########
@@ -62,6 +63,10 @@ dependencies {
compile project(":sdks:java:extensions:sql:zetasql")
compile project(":sdks:java:io:kafka")
compile project(":sdks:java:testing:test-utils")
+ compile "com.google.api-client:google-api-client:1.30.10"
+ compile "junit:junit:4.13-beta-3"
Review comment:
```suggestion
compile library.java.junit
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org