You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by bo...@apache.org on 2019/08/29 12:44:10 UTC

[impala] 03/07: IMPALA-8901: Fix # links on /catalog page.

This is an automated email from the ASF dual-hosted git repository.

boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 152a76479f61da4ccb58ab00f29df7c6e7d99a45
Author: Anurag Mantripragada <an...@gmail.com>
AuthorDate: Tue Aug 27 21:26:54 2019 -0700

    IMPALA-8901: Fix # links on /catalog page.
    
    After IMPALA-7935, the database links on the top of /catalog page
    that use # links to jump to the part of the page corresponding to
    the particular database is broken because the id is ommitted. This is
    fixed by moving id to a tag which doesn't change if local catalog is
    turned on.
    
    Testing:
    Manually tested the links are working in both local catalog mode and
    V1 mode.
    
    Change-Id: I895742dcaeaf71ecf097b0fec69cc19a3b6f86f4
    Reviewed-on: http://gerrit.cloudera.org:8080/14153
    Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 www/catalog.tmpl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/catalog.tmpl b/www/catalog.tmpl
index 20d9b75..8faf5c1 100644
--- a/www/catalog.tmpl
+++ b/www/catalog.tmpl
@@ -166,9 +166,9 @@ under the License.
 <div class="panel panel-info">
   <div class="panel-heading">
   {{^use_local_catalog}}
-    <a href='catalog_object?object_type=DATABASE&object_name={{name}}' id='{{name}}'>
+    <a href='catalog_object?object_type=DATABASE&object_name={{name}}'>
   {{/use_local_catalog}}
-      <h2 class="panel-title">{{name}}
+      <h2 class="panel-title" id='{{name}}'>{{name}}
       <span class="pull-right">{{num_tables}} table(s)</span></h2>
   {{^use_local_catalog}}
     </a>