[jira] [Commented] (ZOOKEEPER-2853) The lastZxidSeen in FileTxnLog.java is never being assigned

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108701#comment-16108701 ] 

ASF GitHub Bot commented on ZOOKEEPER-2853:
-------------------------------------------

Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/322#discussion_r130566850
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -118,7 +118,7 @@
             fsyncWarningThresholdMS = fsyncWarningThreshold;
         }
     
    -    long lastZxidSeen;
    +    long lastMaxZxidSeen;
    --- End diff --
    
    a compile error. **lastZxidSeen** is still used below



> The lastZxidSeen in FileTxnLog.java is never being assigned
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2853
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
>            Priority: Minor
>             Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> There is log in FileTxnLog#append to track the txn with smaller zxid than the last seen, but the lastZxidSeen is never being assigned, so that log is not printed when it's happened.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)