You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2023/06/27 22:09:26 UTC
[GitHub] [ignite-3] AMashenkov opened a new pull request, #2265: IGNITE-19775 Add index builder to TestBuilders
AMashenkov opened a new pull request, #2265:
URL: https://github.com/apache/ignite-3/pull/2265
https://issues.apache.org/jira/browse/IGNITE-19775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #2265: IGNITE-19775 Add index builder to TestBuilders
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov merged PR #2265:
URL: https://github.com/apache/ignite-3/pull/2265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2265:
URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1246362635
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java:
##########
@@ -67,4 +74,19 @@ public void testSimpleQuery() {
assertNotNull(row);
}
}
+
+ /**
+ * Runs a SELECT query with condition.
+ */
+ @Test
+ public void testQueryWithCondition() {
Review Comment:
The query in the test uses index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #2265:
URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1246181578
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java:
##########
@@ -67,4 +74,19 @@ public void testSimpleQuery() {
assertNotNull(row);
}
}
+
+ /**
+ * Runs a SELECT query with condition.
+ */
+ @Test
+ public void testQueryWithCondition() {
Review Comment:
Not sure I understand why do we need this test
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java:
##########
@@ -45,6 +46,12 @@ public class TestClusterTest {
.addColumn("VAL", NativeTypes.stringOf(64))
.defaultDataProvider(dataProvider)
.end()
+ .addHashIndex()
Review Comment:
It would be better to make index builder as child of table builder:
```
TestBuilders.cluster()
.nodes("N1")
.addTable()
.name("T1")
.distribution(IgniteDistributions.hash(List.of(0)))
.addColumn("ID", NativeTypes.INT32)
.addColumn("VAL", NativeTypes.stringOf(64))
.defaultDataProvider(dataProvider)
.addHashIndex()
.name("IDX_ID")
.addColumn("ID")
.defaultDataProvider(dataProvider)
.end()
.end()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #2265:
URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1247476090
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java:
##########
@@ -67,4 +74,19 @@ public void testSimpleQuery() {
assertNotNull(row);
}
}
+
+ /**
+ * Runs a SELECT query with condition.
+ */
+ @Test
+ public void testQueryWithCondition() {
Review Comment:
I removed the index definition, and this test still passes. Let's make it more robust then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #2265:
URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1247486745
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java:
##########
@@ -45,6 +46,12 @@ public class TestClusterTest {
.addColumn("VAL", NativeTypes.stringOf(64))
.defaultDataProvider(dataProvider)
.end()
+ .addHashIndex()
Review Comment:
You've changed indexes in cluster builder flow, but leave top level builder indexes flow as is. Let's make it consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2265:
URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1246428850
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java:
##########
@@ -45,6 +46,12 @@ public class TestClusterTest {
.addColumn("VAL", NativeTypes.stringOf(64))
.defaultDataProvider(dataProvider)
.end()
+ .addHashIndex()
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org