You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/12/14 14:32:00 UTC
[jira] [Commented] (QPIDJMS-544) JmsDefaultPrefetchPolicy#getMaxPrefetchLimit logs incorrect MAX_PREFETCH_SIZE
[ https://issues.apache.org/jira/browse/QPIDJMS-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459191#comment-17459191 ]
ASF subversion and git services commented on QPIDJMS-544:
---------------------------------------------------------
Commit f7dee1b407ef6b8f6939c4569581a8c9eda63195 in qpid-jms's branch refs/heads/0.x from Robbie Gemmell
[ https://gitbox.apache.org/repos/asf?p=qpid-jms.git;h=f7dee1b ]
QPIDJMS-544: log the variable value rather than constant, ensure correctness should the former ever be updated, tweak message for clarity
(cherry picked from commit f5f3cd95e3e7909af45a8e3532b9bb0adea9760a)
> JmsDefaultPrefetchPolicy#getMaxPrefetchLimit logs incorrect MAX_PREFETCH_SIZE
> -----------------------------------------------------------------------------
>
> Key: QPIDJMS-544
> URL: https://issues.apache.org/jira/browse/QPIDJMS-544
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
> Affects Versions: 1.0.0, 1.1.0
> Reporter: Alexander Scott
> Assignee: Robbie Gemmell
> Priority: Trivial
> Fix For: 1.2.0
>
>
> When using the `JmsDefaultPrefetchPolicy` and setting a prefetch limit, prefetch values greater than the `maxPrefetchSize` are logged as being reset to the `MAX_PREFETCH_SIZE`. I believe `MAX_PREFETCH_SIZE` should be changed to `maxPrefetchSize`.
>
>
> {noformat}
> private int getMaxPrefetchLimit(int value) {
> int result = Math.min(value, maxPrefetchSize);
> if (result < value) {
> LOG.warn("maximum prefetch limit has been reset from " + value + " to " + MAX_PREFETCH_SIZE);
> }
> return result;
> }{noformat}
>
>
> {noformat}
> private int getMaxPrefetchLimit(int value) {
> int result = Math.min(value, maxPrefetchSize);
> if (result < value) {
> LOG.warn("maximum prefetch limit has been reset from " + value + " to " + maxPrefetchSize);
> }
> return result;
> }{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org