[jira] [Commented] (WHIMSY-213) Secretary workbench message hash is not guaranteed unique

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIMSY-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664325#comment-16664325 ] 

Sebb commented on WHIMSY-213:
-----------------------------

In the case of the secretary deliver.rb, the message id could be picked up from the parsed headers.

However this would change the generated hash if any existing mails are reprocessed.

Since the same issue applies to the other deliver.rb script, which does not parse the mail, it might be better to handle the wrapped message ID line instead.

> Secretary workbench message hash is not guaranteed unique
> ---------------------------------------------------------
>
>                 Key: WHIMSY-213
>                 URL: https://issues.apache.org/jira/browse/WHIMSY-213
>             Project: Whimsy
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Major
>
> The message hash is generated here [1]. 
> This is not guaranteed unique, as some Message-ID header lines are wrapped; the unique part is on the next line. 
> Further, message IDs themselves may not be unique, though this is much less likely.
> Also AFAICT the code can pick up a Message-ID which is in the body of a message.
> If two such messages arrive in the same month, the second will replace the first.
> If the first message has not been handled, AFAICT it won't ever be processed.
> [1] https://github.com/apache/whimsy/blob/9118c9187f5dc234f5c659caf54e90a7301bb4e3/www/secretary/workbench/models/message.rb#L317



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)