[GitHub] [spark] hvanhovell commented on a diff in pull request #38956: [SPARK-41319][CONNECT][PYTHON] Implement Column.{when, otherwise} and Function `when` with `UnresolvedFunction`

[GitBox <gi...@apache.org>]

hvanhovell commented on code in PR #38956:
URL: https://github.com/apache/spark/pull/38956#discussion_r1047952066


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala:
##########
@@ -161,6 +161,13 @@ case class CaseWhen(
     elseValue: Option[Expression] = None)
   extends ComplexTypeMergingExpression with ConditionalExpression {
 
+  def this(branches: Seq[Expression]) = this(

Review Comment:
   Can we use the `CaseWhen.createFromParser`? You will need to register an `ExpressionBuilder` for this. The upside of this is that it is less messy in the constructor, and that there is ample testing for this from the parser.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org