[GitHub] [hadoop] sunchao commented on a change in pull request #2256: HDFS-15546. Remove duplicate initializeGenericKeys method when creating DFSZKFailoverController

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #2256:
URL: https://github.com/apache/hadoop/pull/2256#discussion_r479379964



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
##########
@@ -158,7 +158,7 @@ public static DFSZKFailoverController create(Configuration conf) {
           "You may run zkfc on the node other than namenode.";
       throw new HadoopIllegalArgumentException(msg);
     }
-    NameNode.initializeGenericKeys(localNNConf, nsId, nnId);

Review comment:
       In `NNHAServiceTarget` the call is on a copy of `localNNConf` though so the original conf will not be set.

##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSZKFailoverController.java
##########
@@ -226,9 +228,11 @@ public void testWithBindAddressSet() throws Exception {
     DFSZKFailoverController zkfc = DFSZKFailoverController.create(
         conf);
     String addr = zkfc.getRpcAddressToBindTo().getHostString();
+    String nameserviceId = conf.get(DFS_NAMESERVICE_ID);
 
     assertEquals("Bind address " + addr + " is not wildcard.",
         addr, WILDCARD_ADDRESS);
+    assertEquals(nameserviceId, NAMESERVICE_ID);

Review comment:
       nit: `assertEquals(expected, actual)`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org