You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "JiajunBernoulli (via GitHub)" <gi...@apache.org> on 2023/05/15 01:57:36 UTC

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3201: [CALCITE-5626] Sub-query with fully qualified table name throws table not found exception in validation phase

JiajunBernoulli commented on code in PR #3201:
URL: https://github.com/apache/calcite/pull/3201#discussion_r1193260919


##########
core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java:
##########
@@ -258,6 +258,9 @@ public SqlIdentifier getId() {
   }
 
   @Override public @Nullable SqlValidatorTable getTable() {
+    if (resolvedNamespace == null) {
+      validator.validateNamespace(this, validator.unknownType);
+    }
     return resolvedNamespace == null ? null : resolve().getTable();

Review Comment:
   Above processed `resolvedNamespace == null`, 
   do we still `resolvedNamespace == null ?` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org