You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "julianhyde (via GitHub)" <gi...@apache.org> on 2023/01/31 02:35:51 UTC

[GitHub] [calcite] julianhyde commented on a diff in pull request #3054: (do not check in)

julianhyde commented on code in PR #3054:
URL: https://github.com/apache/calcite/pull/3054#discussion_r1091366939


##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -659,6 +659,8 @@ SELECT LENGTH("hello") as length;
 #####################################################################
 # DATE
 #
+# 0. DATE(string)
+#   Shorthand for 'CAST(string AS DATE)'

Review Comment:
   Calcite also allows implicit conversions. But when choosing between several overloads of the same function, it should choose the one with the fewest conversions. I'll respond in 5509.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org