[GitHub] [rocketmq] Jason918 commented on a change in pull request #3365: [ISSUE #3366] Allocate MessageQueue to client first by same Machine IP.

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #3365:
URL: https://github.com/apache/rocketmq/pull/3365#discussion_r725611259



##########
File path: client/src/main/java/org/apache/rocketmq/client/consumer/AllocateMessageQueueStrategy.java
##########
@@ -27,13 +30,16 @@
     /**
      * Allocating by consumer id
      *
+     * @param topicRouteData runtime info of topic route data, use it when you need broker info to allocate,
+     *                       if don't use it, can be null.
      * @param consumerGroup current consumer group
      * @param currentCID current consumer id
      * @param mqAll message queue set in current topic
      * @param cidAll consumer set in current consumer group
      * @return The allocate result of given strategy
      */
     List<MessageQueue> allocate(
+        final TopicRouteData topicRouteData,

Review comment:
       Maybe it's better to avoid adding so many nulls in original strategy calls by retain the origin interface here with default method implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org