You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2015/03/03 12:26:59 UTC
Review Request 31677: stout: Make the counting of netmask set bits
more efficient.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31677/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0
Diff: https://reviews.apache.org/r/31677/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 31677: stout: Make the counting of netmask set
bits more efficient.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31677/#review74976
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
<https://reviews.apache.org/r/31677/#comment121852>
this should almost certainly be wrapped in a utility method elsewhere in stout.
stout/bits.hpp?
other useful utilities would be aligning addresses, etc.
- Dominic Hamon
On March 3, 2015, 8:22 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31677/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 8:22 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0
>
> Diff: https://reviews.apache.org/r/31677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 31677: stout: Make the counting of netmask set
bits more efficient.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31677/
-----------------------------------------------------------
(Updated March 3, 2015, 4:22 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0
Diff: https://reviews.apache.org/r/31677/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 31677: stout: Make the counting of netmask set
bits more efficient.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31677/#review74957
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
<https://reviews.apache.org/r/31677/#comment121836>
I don't think this is what you wanted to upload.
- Alexander Rojas
On March 3, 2015, 12:26 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31677/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 12:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0
>
> Diff: https://reviews.apache.org/r/31677/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>