You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/05/24 07:43:00 UTC
[GitHub] [echarts] jiawulin001 opened a new pull request, #17098: fix: markArea of bar series now covers whole categories specified
jiawulin001 opened a new pull request, #17098:
URL: https://github.com/apache/echarts/pull/17098
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
MarkArea in `bar series/category axis` now covers the categories specified rather than area between bars of specified categories.
### Fixed issues
- fix #3573
- fix #17021
- fix #12341
## Details
### Before: What was the problem?
MarkArea in `barSeries/category-axis` is marking the area between bars of category specified, which is not wanted in category axis chart.
|#3573||
|--|--|
|#12341||
|--|--|
|#17021||
### After: How is it fixed in this PR?
Now markArea marks the whole category zones specified. Multi-bars and invert input are both considered.
### Left MarkArea
```
markArea: {
data: [
[
{
name: `Invert input`,
xAxis: 'Thu'
},
{
xAxis: 'Mon'
}
]
]
}
```
### Left MarkArea
```
markArea: {
data: [
[
{
name: 'Single Emphasis',
xAxis: 'Sun'
},
{
xAxis: 'Sun'
}
]
]
}
```
<img width="823" alt="after #17021" src="https://user-images.githubusercontent.com/14244944/169975796-ee6fc11a-a619-4ad1-ac5a-722f6b49c5dc.png">
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
bar-markArea.html
## Others
### Merging options
- [x] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1153376102
@Ovilia Thank you for guiding me to visual test. However since "Run all test" takes forever to run, I run the test relative to `markArea` and `markLine` and the result is as followed. The first test case is added by me, so it's expected to see differences there and no other test cases are affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] andrius-kurtinaitis commented on pull request #17098: fix(marker): `markArea` of bar series now covers whole specified categories
Posted by GitBox <gi...@apache.org>.
andrius-kurtinaitis commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1366460681
It seems this PR breaks zoom functionality: https://github.com/apache/echarts/issues/18099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] ily-salamat commented on pull request #17098: fix(marker): `markArea` of bar series now covers whole specified categories
Posted by GitBox <gi...@apache.org>.
ily-salamat commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1368802199
Since version 5.4.1 the markArea in my bar chart is broken, I think it's related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1153644579
@jiawulin001 Thanks for running the visual tests! I think you are working with the unexpected test results, right?
> Also it's very time consuming to run all visual tests. It takes 40+ minutes to execute all of them. Is there a way to solve or improve this?
Usually, we only do a thorough test before releasing a new version or the PR changes a lot of logic or the reviewers are not very confident with the changes. For PRs like this, test the files that contain "mark" in their names should be enough. But a thorough test is always helpful so thanks for the effort and time! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] dynamikus commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
dynamikus commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1139701560
Any plans to merge this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
Ovilia merged PR #17098:
URL: https://github.com/apache/echarts/pull/17098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] dynamikus commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
dynamikus commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1141516037
@jiawulin001
Thank you for looking into this. Sorry if my questions sounded condescending or demanding that was never my attention.
Keep up with the great work 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1193050663
@Ovilia Hi, I think I've resolved the conflict in merging. Any other suggestions on how should I improve this PR? Or should we move forward to merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1154900420
I have another question regarding visual test. When I am doing all kinds of PR, is there a criterion how I pick what visual tests to do and how should I present the results to the community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on pull request #17098: fix(marker): `markArea` of bar series now covers whole specified categories
Posted by GitBox <gi...@apache.org>.
plainheart commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1368806984
@ily-salamat Hi, thanks for your report! Please create a new issue and make a reference to this PR. We'll try to confirm and fix it in v5.5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1148373076
@Ovilia A new test case in the same html is added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1154912342
> I have another question regarding visual test. When I am doing all kinds of PR, is there a criterion how I pick what visual tests to do and how should I present the results to the community?
If you want to export the report, there's a "ALL RUNS" button on the menu. Check the versions and time to know which running should be exported and click "report" to export.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1148099108
> I would like to see more test cases
@Ovilia More test cases are on the way.
>Sorry if my questions sounded condescending or demanding that was never my attention.
Thank you for your applause, and it's totally fine to ask. I am really glad if my work can help someone else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1154887668
My apologies for those lint fix commits! I've been using github desktop to submit commits and the hooks seem not to work on it. I'll use my IDE to submit commits and make sure I execute lint scripts before them in the future. Thank you for your reminding!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1149510302
@jiawulin001 Thanks! Please also run the [visual test](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request#run-test-cases) for all cases and see if there are diffs that we should be aware of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] SevenOutman commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
SevenOutman commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1190068407
Any update on this PR? Would help a lot as neither markArea or splitArea is working correctly today in bar charts with dataZoom :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1255817828
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: `PR: doc ready`, `PR: awaiting doc`, `PR: doc unchanged`
This message is shown because the PR description doesn't contain the document related template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on pull request #17098: fix(marker): `markArea` of bar series now covers whole specified categories
Posted by GitBox <gi...@apache.org>.
plainheart commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1368811881
Also, thank you @andrius-kurtinaitis for filing a similar bug. I've marked your issue as high-priority and will fix it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1153673978
> I think you are working with the unexpected test results, right?
If you mean the issues of `markPoint`, it's been resolved in the update. No other issues occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1140471222
This PR looks awesome! I would like to see more test cases, for example, when `xAxis` and `yAxis` are both configured in the data, or `x` and `y` values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1255817920
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1255793182
> Hi, Is there any plan to merge the problem to the latest version in the near future? @Ovilia 🤔️
This PR is scheduled in 5.4.1, which should be published in November.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1140470478
@dynamikus Thanks for your contribution and please be patient to wait for reviews since we are mostly working part-time on the project. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] ysldnadotme commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
ysldnadotme commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1250811454
Hi, Is there any plan to merge the problem to the latest version in the near future? @Ovilia 🤔️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1135523378
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on pull request #17098: fix: markArea of bar series now covers whole categories specified
Posted by GitBox <gi...@apache.org>.
plainheart commented on PR #17098:
URL: https://github.com/apache/echarts/pull/17098#issuecomment-1154750569
Hi @jiawulin001, Thanks for your recent contributions! They help a lot! It would be better if you could check the reason why the configured `husky` hook and ESLint plugin don't work for you. It can give you on-time corresponding warnings and fixing strategies and reduce extra commits that fix lint issues after you make them work normally. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org