You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/22 15:45:46 UTC
[GitHub] [skywalking-satellite] mrproliu opened a new pull request #86: Setup full configuration, each config could be setup from environment
mrproliu opened a new pull request #86:
URL: https://github.com/apache/skywalking-satellite/pull/86
Mostly is update the gRPC client configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #86: Setup full configuration, each config could be setup from environment
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #86:
URL: https://github.com/apache/skywalking-satellite/pull/86#issuecomment-975666713
I remember you used to add k8s service discovery, do I remember wrongly or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #86: Setup full configuration, each config could be setup from environment
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #86:
URL: https://github.com/apache/skywalking-satellite/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #86: Setup full configuration, each config could be setup from environment
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #86:
URL: https://github.com/apache/skywalking-satellite/pull/86#discussion_r754409942
##########
File path: configs/satellite_config.yaml
##########
@@ -37,8 +37,55 @@ telemetry:
sharing:
clients:
- plugin_name: "grpc-client"
+ # The gRPC server address finder type
+ finder_type: ${SATELLITE_GRPC_CLIENT_FINDER:static}
Review comment:
It is better to list all options here.
##########
File path: docs/en/setup/plugins/client_grpc-client.md
##########
@@ -30,6 +45,7 @@ check_period: 5
## Configuration
|Name|Type|Description|
|----|----|-----------|
+| finder_type | string | The gRPC server address finder type |
Review comment:
Please describe how to activate different finders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu edited a comment on pull request #86: Setup full configuration, each config could be setup from environment
Posted by GitBox <gi...@apache.org>.
mrproliu edited a comment on pull request #86:
URL: https://github.com/apache/skywalking-satellite/pull/86#issuecomment-975678797
> I remember you used to add k8s service discovery, do I remember wrongly or something?
Yes, the k8s service discovery has been added. This PR use to setup all the configuration in the default config, so user could setup different GRPC client from environment, rather than create a new config to rewrite the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #86: Setup full configuration, each config could be setup from environment
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #86:
URL: https://github.com/apache/skywalking-satellite/pull/86#discussion_r754759028
##########
File path: docs/en/setup/plugins/client_grpc-client.md
##########
@@ -30,6 +45,7 @@ check_period: 5
## Configuration
|Name|Type|Description|
|----|----|-----------|
+| finder_type | string | The gRPC server address finder type |
Review comment:
been added to the example file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on pull request #86: Setup full configuration, each config could be setup from environment
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #86:
URL: https://github.com/apache/skywalking-satellite/pull/86#issuecomment-975678797
> I remember you used to add k8s service discovery, do I remember wrongly or something?
Yes, the k8s service discovery has been added. This PR maintain to setup all the configuration in the default config, so user could setup different GRPC client from environment, rather than create a new config to rewrite the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #86: Setup full configuration, each config could be setup from environment
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #86:
URL: https://github.com/apache/skywalking-satellite/pull/86#issuecomment-976003162
OK, then, please make the config more clear about how to activate k8s upstream service discovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org